All users were logged out of Bugzilla on October 13th, 2018

(a) = ...; aborts syntax parsing

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla36
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I was just looking into JSBench performance and noticed we abort syntax parsing for (a) = ... (assignment with parentheses around LHS).

The abort happens in checkAndMarkAsAssignmentLhs, because pn is SyntaxParseHandler::NodeGeneric.

This should improve the facebook/chrome and facebook/firefox tests by about 10%.

Simple testcase:

function f() {
    function g() {
	var a;
	(a) = 3;
    }
    return 3;
}
f();
(Assignee)

Comment 1

4 years ago
Created attachment 8509407 [details] [diff] [review]
Patch
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8509407 - Flags: review?(bhackett1024)
Attachment #8509407 - Flags: review?(bhackett1024) → review+
https://hg.mozilla.org/mozilla-central/rev/d6d519cc677b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36

Updated

4 years ago
Blocks: 1111101
You need to log in before you can comment on or make changes to this bug.