1085071 - Drop support for JSPropertyOp getters/setters in sandboxes

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We added this at some point, when we still had DOM stuff that was JSPropertyOp, but that hasn't been the case in a while.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop handling JSPropertyOp getters/setters in sandbox code, since we no longer have those around for any of the objects we care about

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8507485 [details] [diff] [review]
Stop handling JSPropertyOp getters/setters in sandbox code, since we no longer have those around for any of the objects we care about

Review of attachment 8507485 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/Sandbox.cpp
@@ +633,5 @@
>      // Now fix up the getter/setter/value as needed to be bound to desc->obj.
>      //
>      // Don't mess with XPC_WN_Helper_GetProperty and XPC_WN_Helper_SetProperty,
>      // because that could confuse our access to expandos.
>      if (desc.getter() != XPC_WN_Helper_GetProperty &&

Can't we get rid of these two checks now, and the extern declarations above?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Can't we get rid of these two checks now, and the extern declarations above?

Looks like we can, now that window is not on XPConnect bindings.  I'll do that.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, and I verified that by running the manual test in bug 751077, and of course try.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5d5e03408f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad5d5e03408f