Drop support for JSPropertyOp getters/setters in sandboxes

RESOLVED FIXED in mozilla36

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla36
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We added this at some point, when we still had DOM stuff that was JSPropertyOp, but that hasn't been the case in a while.
Comment on attachment 8507485 [details] [diff] [review]
Stop handling JSPropertyOp getters/setters in sandbox code, since we no longer have those around for any of the objects we care about

Review of attachment 8507485 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/Sandbox.cpp
@@ +633,5 @@
>      // Now fix up the getter/setter/value as needed to be bound to desc->obj.
>      //
>      // Don't mess with XPC_WN_Helper_GetProperty and XPC_WN_Helper_SetProperty,
>      // because that could confuse our access to expandos.
>      if (desc.getter() != XPC_WN_Helper_GetProperty &&

Can't we get rid of these two checks now, and the extern declarations above?
Attachment #8507485 - Flags: review?(bobbyholley) → review+
> Can't we get rid of these two checks now, and the extern declarations above?

Looks like we can, now that window is not on XPConnect bindings.  I'll do that.
Oh, and I verified that by running the manual test in bug 751077, and of course try.
https://hg.mozilla.org/mozilla-central/rev/ad5d5e03408f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1087374
You need to log in before you can comment on or make changes to this bug.