1087374 - Gecko Profiler 1.13.7 addon does not work in Nightly36.0a1, The tab displays "Symbolicating..." forever.

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Alice0775 White]

when I click "Analyze" of Gecko Profiler 1.13.7,
A "Cleopatra - UI for SPS" tab opened, However, The tab displays "Symbolicating..." forever.
And the following error is shown in Browser Console.

Exception { message: "Unexpected error", result: 2147549183, name: "NS_ERROR_UNEXPECTED", filename: "resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/sandbox.js line 164 > Function", lineNumber: 1, columnNumber: 0, inner: null, data: null, stack: "anonymous@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/content/sandbox.js line 164 > Function:1:0
@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/geckoprofiler/data/cleopatra.js:68:0
onEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:21
onEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:21
onChromeEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/fuku/AppData/Roaming/Mozilla/Firefox/Profiles/efdr3iyn.profiler/extensions/[e-mail]!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:91:15
" } timers.js:43

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Regression window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/290f799b4f58
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141020181618
Bad "Symbolicating...":
https://hg.mozilla.org/mozilla-central/rev/29fbfc1b31aa
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141020185824
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=290f799b4f58&tochange=29fbfc1b31aa


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0970007a8468
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141020095912
Bad "Symbolicating...":
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5d5e03408f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141020100613
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0970007a8468&tochange=ad5d5e03408f

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yeah, alright.

So we're hitting the jspropertyop case, with xpc::wrappedJSObject_getter as the op.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Make .wrappedJSObject on Xrays a JSNative accessor

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8509650 [details] [diff] [review]
Make .wrappedJSObject on Xrays a JSNative accessor

Review of attachment 8509650 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/XrayWrapper.cpp
@@ +1254,1 @@
>      if (!IsWrapper(wrapper) || !WrapperFactory::IsXrayWrapper(wrapper)) {

Now that this call/apply-able, please add || !AccessCheck::wrapperSubsumes(wrapper) here.

Comment 5

[Boris Zbarsky [:bzbarsky]]

> Now that this call/apply-able, please add || !AccessCheck::wrapperSubsumes(wrapper) here.

Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/845ed7d822bd

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/845ed7d822bd

Comment 7

[Alice0775 White]

I can verify that the problem is fixed on the following Nightly build.

https://hg.mozilla.org/mozilla-central/rev/a5ee2769eb27
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141024030200