Closed
Bug 1085199
Opened 10 years ago
Closed 10 years ago
[B2G][RIL] don't need wrapDomRequestAsPromise in marionette tests anymore
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: hsinyi, Assigned: ehsan.akhgari)
References
Details
Attachments
(2 files)
|
7.57 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
|
1.84 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
DOMRequest now has a .then() method compatible with Promise since bug 839838.
We could remove the wrap in [1], [2]
[1] http://dxr.mozilla.org/mozilla-central/source/dom/mobileconnection/tests/marionette/head.js#91
[2] http://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/tests/marionette/head.js#31
|
Assignee | |
Comment 1•10 years ago
|
||
I have patches for all of these, but I need to test them on the try server...
Assignee: nobody → ehsan.akhgari
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8507866 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8507867 -
Flags: review?(htsai)
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8507866 [details] [diff] [review]
Part 1
Review of attachment 8507866 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you Ehsan!
Attachment #8507866 -
Flags: review?(htsai) → review+
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8507867 -
Flags: review?(htsai) → review+
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a14ea084786
https://hg.mozilla.org/mozilla-central/rev/3b4082fc74ab
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•