1085251 - [Contacts] Pick Contact Activity does not show the dismiss button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jose Manuel Cantera]

STR: go to the messages app --> new message --> tap on the '+' button to add a new contact --> the pick contact activity is launched and showed but the 'x' button does not appear and the title is not properly changed to 'Select Contact' .

Comment 1

[Jose Manuel Cantera]

Attachment: 25311.html

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

I don't think we should work on this bug during this sprint.

Comment 4

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #3)
> I don't think we should work on this bug during this sprint.

why?

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

(dupe bug 1083287 is 2.2+)

Comment 6

[Jose Manuel Cantera]

Johan,

does this happen on v2.1 ?

thanks

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Jose Manuel Cantera from comment #4)
> (In reply to Francisco Jordano [:arcturus] [:francisco] from comment #3)
> > I don't think we should work on this bug during this sprint.
> 
> why?

Cause it wasn't planned. If it's a regression and it happens in 2.1 definitely we will need to fix it ASAP, otherwise I would like to keep strict to the plan.

If we run out of bugs in this sprint, let's fix it!

Comment 8

[Johan Lorenzo [:jlorenzo]]

(In reply to Jose Manuel Cantera from comment #6)
> does this happen on v2.1 ?

No, it doesn't. The dismiss button is present and I am able to tap on it to go back.

Comment 9

[Johan Lorenzo [:jlorenzo]]

(In reply to Jose Manuel Cantera from comment #0)
> and the title is not properly changed to 'Select Contact'.

"Select Contact" is also not displayed in 2.1.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8507733 [details]
25311.html

Great patch, simplifies a lot the original messy code.

Tried on the phone and working perfect.

Comment 11

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/742074645c79a2cd3f35e1419de18d6886e0966d

Comment 12

[Jose Manuel Cantera]

Comment on attachment 8507733 [details]
25311.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual Refresh
[User impact] if declined: Relatively low. inconsistent UI
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk patch. alternative is an inconsistent UI shown to the user
[String changes made]: none

Comment 13

[Johan Lorenzo [:jlorenzo]]

Checked on 2.0 too, the title is not changed to "Select contacts" after taping the + button when writing a new message.

Gaia-Rev        63b56a7a7453726b9e12ad1afe02c68c83c5aeca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/40584eecdc75
Build-ID        20141021000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Comment 14

[bhavana bajaj [:bajaj]]

Thanks for the quick check, Johan. 

Jose, really appreciate the fix here but I do not think this is a blocker to ship 2.1 and at this point we want to limit the code-churn and land only critical fixes that are needed for the release. So, given this is on master already, this will automatically get fixed in 2.2 and we will have to live with it in the short-term :(

Comment 15

[bhavana bajaj [:bajaj]]

Updating the title as this is not a 2.1 regression.

Comment 16

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

It was fixed on master (future 2.2) already