Closed
Bug 1085251
Opened 10 years ago
Closed 10 years ago
[Contacts] Pick Contact Activity does not show the dismiss button
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:-, b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 affected)
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
Attachments
(1 file)
191 bytes,
text/html
|
arcturus
:
review+
bajaj
:
approval-gaia-v2.1-
|
Details |
STR: go to the messages app --> new message --> tap on the '+' button to add a new contact --> the pick contact activity is launched and showed but the 'x' button does not appear and the title is not properly changed to 'Select Contact' .
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8507733 -
Flags: review?(francisco)
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S7 (24Oct)
Comment 3•10 years ago
|
||
I don't think we should work on this bug during this sprint.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #3) > I don't think we should work on this bug during this sprint. why?
Assignee | ||
Comment 6•10 years ago
|
||
Johan, does this happen on v2.1 ? thanks
Flags: needinfo?(jlorenzo)
Comment 7•10 years ago
|
||
(In reply to Jose Manuel Cantera from comment #4) > (In reply to Francisco Jordano [:arcturus] [:francisco] from comment #3) > > I don't think we should work on this bug during this sprint. > > why? Cause it wasn't planned. If it's a regression and it happens in 2.1 definitely we will need to fix it ASAP, otherwise I would like to keep strict to the plan. If we run out of bugs in this sprint, let's fix it!
Comment 8•10 years ago
|
||
(In reply to Jose Manuel Cantera from comment #6) > does this happen on v2.1 ? No, it doesn't. The dismiss button is present and I am able to tap on it to go back.
Comment 9•10 years ago
|
||
(In reply to Jose Manuel Cantera from comment #0) > and the title is not properly changed to 'Select Contact'. "Select Contact" is also not displayed in 2.1.
Comment 10•10 years ago
|
||
Comment on attachment 8507733 [details]
25311.html
Great patch, simplifies a lot the original messy code.
Tried on the phone and working perfect.
Attachment #8507733 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 11•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/742074645c79a2cd3f35e1419de18d6886e0966d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8507733 [details]
25311.html
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual Refresh
[User impact] if declined: Relatively low. inconsistent UI
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk patch. alternative is an inconsistent UI shown to the user
[String changes made]: none
Attachment #8507733 -
Flags: approval-gaia-v2.1?
Comment 13•10 years ago
|
||
Checked on 2.0 too, the title is not changed to "Select contacts" after taping the + button when writing a new message. Gaia-Rev 63b56a7a7453726b9e12ad1afe02c68c83c5aeca Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/40584eecdc75 Build-ID 20141021000201 Version 32.0 Device-Name flame FW-Release 4.4.2 FW-Incremental 39 FW-Date Thu Oct 16 18:19:14 CST 2014 Bootloader L1TC00011880
status-b2g-v2.0:
--- → affected
Comment 14•10 years ago
|
||
Thanks for the quick check, Johan. Jose, really appreciate the fix here but I do not think this is a blocker to ship 2.1 and at this point we want to limit the code-churn and land only critical fixes that are needed for the release. So, given this is on master already, this will automatically get fixed in 2.2 and we will have to live with it in the short-term :(
Updated•10 years ago
|
Attachment #8507733 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1-
Comment 15•10 years ago
|
||
Updating the title as this is not a 2.1 regression.
Summary: [Contacts] [Regression] Pick Contact Activity does not show the dismiss button → [Contacts] Pick Contact Activity does not show the dismiss button
You need to log in
before you can comment on or make changes to this bug.
Description
•