1085290 - [Bluetooth][Settings] Support version detection for Bluetooth module/panel between v1/v2 API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[[e-mail], [e-mail]]

This bug will support version detection for v1/v2 API. And will create a new Bluetooth panel to leave the old code base.

Comment 1

[[e-mail], [e-mail]]

Attachment: pull request 25320

Arthur, per offline discussion, we separate the version detection and new panel implementation from bug 1070823. This patch is arming to complete as description. And ensure we won't load useless module on incorrect API version. Could you please help to review my pull request? And I will keep to add unit test. Thanks.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8507795 [details] [review]
pull request 25320

Most of the code looks good to me, please check my comments in github, thanks!

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8507795 [details] [review]
pull request 25320

Arthur, I have updated the patch. And add some unit test to cover these change. Thanks for guiding 'Promise' usage. That is very useful for async call. Will need your review again.

Addition:

* Dynamically load modules/bluetooth_v? via version detection.
* Use Promise to get Bluetooth module.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8507795 [details] [review]
pull request 25320

Looks much better now. Please check my comments in github, thanks.

Comment 5

[[e-mail], [e-mail]]

Comment on attachment 8507795 [details] [review]
pull request 25320

Already updated the patch with your suggestion. Thanks for the reviewing effort.:)

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8507795 [details] [review]
pull request 25320

r=me with the last comments addressed, thanks!

Comment 7

[[e-mail], [e-mail]]

Updated the patch for last comments address. And will land the pr after pass all test on try-server.

Comment 8

[[e-mail], [e-mail]]

Since passed on try-server and landed, we can close the issue now.

Gaia/master:  da95f7d329bc1cbd523a2439edf171f082809e1b