1085292 - B2G NFC: After taglost, the tag object got in ontagfound should be invalid.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

After Bug 991970 is landed, the tag object should be invalid after ontaglost is called.
Calling those MozNFCTag APIs on the tag object should throw.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Patch

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8514109 [details] [diff] [review]
Patch

Review of attachment 8514109 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Yoshi,
Looks good, but one question before r+ this patch.
Why do we need to to expose invalidate API in WebIDL instead of handle isLost in notifyTagLost and notifyPeerLost?

::: dom/webidl/MozNFCPeer.webidl
@@ +24,5 @@
> +  [ChromeOnly]
> +  void invalidate();
> +
> +  /**
> +   * Indicate if this tag is already lost.

Nits. this peer

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

(In reply to Dimi Lee[:dimi][:dlee] from comment #2)
> Comment on attachment 8514109 [details] [diff] [review]
> Patch
> 
> Review of attachment 8514109 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Hi Yoshi,
> Looks good, but one question before r+ this patch.
> Why do we need to to expose invalidate API in WebIDL instead of handle
> isLost in notifyTagLost and notifyPeerLost?
> 
Use isLost only is also okay. I'll remove invalidate.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Patch. v2.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Comment on attachment 8514765 [details] [diff] [review]
Patch. v2.

Review of attachment 8514765 [details] [diff] [review]:
-----------------------------------------------------------------

add r? to smaug for the WebIDL changed.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

https://hg.mozilla.org/integration/b2g-inbound/rev/00b7445bcb49

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00b7445bcb49