Closed
Bug 1085292
Opened 10 years ago
Closed 10 years ago
B2G NFC: After taglost, the tag object got in ontagfound should be invalid.
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file, 1 obsolete file)
8.07 KB,
patch
|
dlee
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
After Bug 991970 is landed, the tag object should be invalid after ontaglost is called. Calling those MozNFCTag APIs on the tag object should throw.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → allstars.chh
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8514109 -
Flags: review?(dlee)
Comment 2•10 years ago
|
||
Comment on attachment 8514109 [details] [diff] [review] Patch Review of attachment 8514109 [details] [diff] [review]: ----------------------------------------------------------------- Hi Yoshi, Looks good, but one question before r+ this patch. Why do we need to to expose invalidate API in WebIDL instead of handle isLost in notifyTagLost and notifyPeerLost? ::: dom/webidl/MozNFCPeer.webidl @@ +24,5 @@ > + [ChromeOnly] > + void invalidate(); > + > + /** > + * Indicate if this tag is already lost. Nits. this peer
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Dimi Lee[:dimi][:dlee] from comment #2) > Comment on attachment 8514109 [details] [diff] [review] > Patch > > Review of attachment 8514109 [details] [diff] [review]: > ----------------------------------------------------------------- > > Hi Yoshi, > Looks good, but one question before r+ this patch. > Why do we need to to expose invalidate API in WebIDL instead of handle > isLost in notifyTagLost and notifyPeerLost? > Use isLost only is also okay. I'll remove invalidate.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8514109 -
Attachment is obsolete: true
Attachment #8514109 -
Flags: review?(dlee)
Attachment #8514765 -
Flags: review?(dlee)
Updated•10 years ago
|
Attachment #8514765 -
Flags: review?(dlee) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8514765 [details] [diff] [review] Patch. v2. Review of attachment 8514765 [details] [diff] [review]: ----------------------------------------------------------------- add r? to smaug for the WebIDL changed.
Attachment #8514765 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8514765 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/00b7445bcb49
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S8 (7Nov)
Assignee | ||
Updated•10 years ago
|
No longer blocks: b2g-nfc-privilege
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/00b7445bcb49
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Blocks: b2g-nfc-privilege
You need to log in
before you can comment on or make changes to this bug.
Description
•