1085301 - B2G NFC: checking sessionToken in notifyPeerReady is unneccesary.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In notifyPeerReady from nsNfc.js it will call getNFCPeer to get the peer object, however the getNFCPeer will also do the session check, which is not neccesary.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Dimi Lee [ooo Mar. 28 - Apr. 6]]

Comment on attachment 8517173 [details] [diff] [review]
Patch

Review of attachment 8517173 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/nsNfc.js
@@ +202,5 @@
>  
> +  _createNFCPeer: function _createNFCPeer(sessionToken) {
> +    let peer = new MozNFCPeerImpl(this._window, sessionToken);
> +    this.nfcPeer = this._window.MozNFCPeer._create(this._window, peer);
> +    return this.nfcPeer;

_createNFCPeer is a private function of mozNfc and this function set both |this.ncPeer| member variable and return this member variable.
I think it would be better just:
return this._window.MozNFCPeer._create(this._window, peer);

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

move assigning this.nfcPeer outside.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/9e4830e71a20

Comment 5

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/9e4830e71a20