1085374 - Awesome Bar: Firefox suggests "[keyword] – Search with [default search engine]" when entering "[keyword][space]", but loads the search engine related to the keyword

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Tim [:pollti]]

When I have Google as default search engine and the keyword "y" for yahoo search in Firefox 35 or 36:
1. Enter "y " in the Awesome Bar.
   ➔ Firefox shows "y – Search with Google" as a first suggestion
2. When I press Enter or click on the suggestion, Firefox loads yahoo.com

Comment 1

[Marco Bonardo [:mak]]

So while confusing, this would the right behavior.

Search engine aliases only work if you are actually searching for something, like "y some thing", if you type just "y " there's nothing to search and thus we just do a plain search for "y" with the default engine.

The fact we open yahoo though is very wrong.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1)
> So while confusing, this would the right behavior.

Not entirely... it's showing one thing, but doing the other. Bug 1067903 will fix this - it's an inconsistency between what docshell uri fixup does (old and broken, no longer wanted), and what our heuristics (new and shiny, intended implementation) does.

Comment 3

[Marco Bonardo [:mak]]

Blair, you said bug 1067903 was going to fix this. Did it do?

Comment 4

[Marco Bonardo [:mak]]

well, looks like it did. now "y " searches in google like the special row suggests.

Comment 5

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 37.0a1 (2014-12-01) and Aurora 36.0a2 (2014-12-01) using Windows 7 64-bit, Ubuntu 12.04 LTS 32-bit.