1085386 - Back button does not close the settings page on Search Activity

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

Environment: 
Device: Asus Transformer Tab (Android 4.0.3);
Build: Nightly 36.0a1 (2014-10-20);

Steps to reproduce:
1. Launch Search Activity;
2. Go to settings;
3. Tap on the upper left button to exit settings;

Expected result:
Settings menu is closed and the Search Activity is displayed.

Actual result:
Nothing happens when tapping on the back button located on the upper left side of the screen.

Notes:
Not reproducible on Motorola Razr (Andrid 4.1.2).

Comment 1

[Aaron Train [:aaronmt]]

Tablet issue? I couldn't reproduce this on my Nexus 5 here. I don't have a Nexus 7 on me today to try that out.

Comment 2

[Nick Alexander :nalexander [he/him]]

Reproduced on my Samsung Galaxy S2, Android 4.0.3.  margaret cannot reproduce on her Android 4.4.2 device.

Comment 3

[:Margaret Leibovic]

kbrosnan, can you see if there's a device in the SF office where this is happening?

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

I think liuche has this device.

Comment 5

[Chenxia Liu [:liuche]]

I couldn't reproduce on an SII 2.3, Nexus 4 4.4.4, or Galaxy Nexus 4.3.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

I was referring to the tablet with the attached keyboard that normally lives under your monitor. I believe that is the exact model of device that this bug was reported against.

Comment 7

[:Margaret Leibovic]

Attachment: Finish preference activity when hitting action bar "up" button

It looks like newer versions of Android take care of this for you, while older versions don't. I tested this on a Transformer running 4.0.3 (where the bug was present) and an N4 running 4.4.4 (where the bug wasn't present), and they both work fine with this patch applied.

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8522575 [details] [diff] [review]
Finish preference activity when hitting action bar "up" button

Review of attachment 8522575 [details] [diff] [review]:
-----------------------------------------------------------------

Great, lgtm!

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/885334253d3a

Comment 10

[:Margaret Leibovic]

Comment on attachment 8522575 [details] [diff] [review]
Finish preference activity when hitting action bar "up" button

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: "up" button in search activity preferences won't work on some devices
[Describe test coverage new/current, TBPL]: no automated tests, tested locally on multiple devices, just landed on m-c
[Risks and why]: low-risk, adds simple logic to handle a click on a button
[String/UUID change made/needed]: none

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/885334253d3a

Comment 12

[Sudhir]

Can I pick up this issue?

Comment 13

[:Margaret Leibovic]

(In reply to Sudhir from comment #12)
> Can I pick up this issue?

Hi Sudhir, this issue is fixed already (you can see that in the status field at the top of the bug), but there's a list of good starter bugs here if you're looking for something else to fix:
http://www.joshmatthews.net/bugsahoy/?mobile=1&simple=1

Comment 14

[Sudhir]

Hi Margaret,

I am looking for bugs to test in Firefox-Android. I have picked up this bug for fixed bugs. Please let me know if there any.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40cd4f2cbcdb

Comment 16

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in builds:
Firefox for Android 36.0a2 (2014-12-04);
Firefox for Android 35 Beta 1 build 2;

Device: Asus Transformer Tab (Android 4.0.3).