Closed
Bug 1085386
Opened 10 years ago
Closed 10 years ago
Back button does not close the settings page on Search Activity
Categories
(Firefox for Android Graveyard :: Search Activity, defect)
Tracking
(firefox35 verified, firefox36 verified, fennec35+)
VERIFIED
FIXED
Firefox 36
People
(Reporter: cos_flaviu, Assigned: Margaret)
References
Details
Attachments
(1 file)
1.91 KB,
patch
|
liuche
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Environment: Device: Asus Transformer Tab (Android 4.0.3); Build: Nightly 36.0a1 (2014-10-20); Steps to reproduce: 1. Launch Search Activity; 2. Go to settings; 3. Tap on the upper left button to exit settings; Expected result: Settings menu is closed and the Search Activity is displayed. Actual result: Nothing happens when tapping on the back button located on the upper left side of the screen. Notes: Not reproducible on Motorola Razr (Andrid 4.1.2).
Comment 1•10 years ago
|
||
Tablet issue? I couldn't reproduce this on my Nexus 5 here. I don't have a Nexus 7 on me today to try that out.
Comment 2•10 years ago
|
||
Reproduced on my Samsung Galaxy S2, Android 4.0.3. margaret cannot reproduce on her Android 4.4.2 device.
Assignee | ||
Updated•10 years ago
|
tracking-fennec: --- → ?
Updated•10 years ago
|
tracking-fennec: ? → 35+
Assignee | ||
Comment 3•10 years ago
|
||
kbrosnan, can you see if there's a device in the SF office where this is happening?
Comment 4•10 years ago
|
||
I think liuche has this device.
Flags: needinfo?(kbrosnan) → needinfo?(liuche)
Comment 5•10 years ago
|
||
I couldn't reproduce on an SII 2.3, Nexus 4 4.4.4, or Galaxy Nexus 4.3.
Flags: needinfo?(liuche)
Comment 6•10 years ago
|
||
I was referring to the tablet with the attached keyboard that normally lives under your monitor. I believe that is the exact model of device that this bug was reported against.
Assignee | ||
Comment 7•10 years ago
|
||
It looks like newer versions of Android take care of this for you, while older versions don't. I tested this on a Transformer running 4.0.3 (where the bug was present) and an N4 running 4.4.4 (where the bug wasn't present), and they both work fine with this patch applied.
Attachment #8522575 -
Flags: review?(liuche)
Comment 8•10 years ago
|
||
Comment on attachment 8522575 [details] [diff] [review] Finish preference activity when hitting action bar "up" button Review of attachment 8522575 [details] [diff] [review]: ----------------------------------------------------------------- Great, lgtm!
Attachment #8522575 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/885334253d3a
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8522575 [details] [diff] [review] Finish preference activity when hitting action bar "up" button Approval Request Comment [Feature/regressing bug #]: search activity [User impact if declined]: "up" button in search activity preferences won't work on some devices [Describe test coverage new/current, TBPL]: no automated tests, tested locally on multiple devices, just landed on m-c [Risks and why]: low-risk, adds simple logic to handle a click on a button [String/UUID change made/needed]: none
Attachment #8522575 -
Flags: approval-mozilla-aurora?
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/885334253d3a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•10 years ago
|
Attachment #8522575 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•9 years ago
|
||
Can I pick up this issue?
Assignee | ||
Comment 13•9 years ago
|
||
(In reply to Sudhir from comment #12) > Can I pick up this issue? Hi Sudhir, this issue is fixed already (you can see that in the status field at the top of the bug), but there's a list of good starter bugs here if you're looking for something else to fix: http://www.joshmatthews.net/bugsahoy/?mobile=1&simple=1
Comment 14•9 years ago
|
||
Hi Margaret, I am looking for bugs to test in Firefox-Android. I have picked up this bug for fixed bugs. Please let me know if there any.
Comment 15•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/40cd4f2cbcdb
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Comment 16•9 years ago
|
||
Verified as fixed in builds: Firefox for Android 36.0a2 (2014-12-04); Firefox for Android 35 Beta 1 build 2; Device: Asus Transformer Tab (Android 4.0.3).
Updated•6 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•