1085433 - mozregression should support using 64-bit Windows builds

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[William Lachance (:wlach)]

Right now mozregression throws an exception if the user tries to get 64-bit builds under Windows. Since we're planning to ship a 64-bit Firefox on Windows in the near future, we should make mozregression support it.

Steps:

1. Modify the logic of getting the build name to look for 64-bit builds. Primarily this would be here:

https://github.com/mozilla/mozregression/blob/master/mozregression/runnightly.py#L45

Here's an example win64 build URL: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-10-19-03-02-07-mozilla-central/

2. As of this writing, we do not build for 64-bit on mozilla-inbound. This may change soon, but for now we need to modify this logic to not attempt to bisect inbound if the bits are 64 and the platform is windows:

https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L169

This bug is not completely trivial, but shouldn't be too bad for someone with some python experience. If you want to take it on, you should have a 64-bit windows environment set up with the mozilla-build package installed (see instructions at: http://mozilla.github.io/mozregression/). Check out mozregression from http://github.com/mozilla/mozregression and install into a virtualenv (http://virtualenv.readthedocs.org/en/latest/). Then you can modify the program's logic directly using your favorite text editor and test it out.

Comment 1

[Kapil Singh [:kapy]]

Hello,
It is exciting to know that 64 bit version of Firefox is coming out.
I am interested in working on this bug.

Thanks,
Kapil

Comment 2

[William Lachance (:wlach)]

Hi Kapil, thanks for agreeing to take this on. I've assigned this bug to you. If you have questions, please feel free to get in touch on IRC (irc.mozilla.org) #ateam. Someone should be able to help you.

Comment 3

[Kapil Singh [:kapy]]

Attachment: 64 bit Firefox support for Mozregression

I have only fixed runnightly.py, please take a look.
I cannot understand what to do in regression.py, suggest me how to proceed.

Thanks,
Kapil

Comment 4

[Kapil Singh [:kapy]]

Attachment: 64 bit Firefox support for Mozregression

Sorry for the previous attachment, I am having some difficulty with git.
Take a look at this patch for runnightly.py and suggest me what to do with regression.py.

Thnaks,
Kapil

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8509464 [details] [diff] [review]
64 bit Firefox support for Mozregression

This is a good start! So, in regression.py, you'll want to modify the condition to detect that we're testing a 64 bit os on Windows. So you'll need to change the line I mentioned from:

if self.appname in ('firefox', 'fennec', 'b2g'):

to something like:

if self.appname in ('firefox', 'fennec', 'b2g') and not (mozinfo.os == 'win' and bits == 64):

... except that actually won't work as-is because you don't have "bits" defined at that point in the file. I'll leave it to you to figure out how to get that value. :) You'll see that we get the value we need to use from the option parsing later in the file:

https://github.com/mozilla/mozregression/blob/master/mozregression/regression.py#L282

Comment 6

[Kapil Singh [:kapy]]

So, the changes made in runnightly.py is ok ??

Comment 7

[William Lachance (:wlach)]

(In reply to Kapil Singh [:kapy] from comment #6)
> So, the changes made in runnightly.py is ok ??

You will obviously need to test your changes to make sure, but that looks right to me.

Comment 8

[Jukka Jylänki]

We ran into a Firefox regression when debugging an Emscripten-compiled web page of the UE4 engine from Epic Games themselves! Since we mostly use 64-bit Firefox with them, we could say the benefit of mozregression having 64-bit support is now Epic! :)

Comment 9

[Kapil Singh [:kapy]]

Attachment: Adding-support-for-64-bit-Windows-Builds

Hello Will,
I have created the patch that fixes downloads for 64 bit nightly builds of Firefox on Windows.
Please, do take a look.

Thanks,
Kapil

Comment 10

[William Lachance (:wlach)]

Hi Kapil, that looks about right to me, however we need to test to make sure it works. :) Did you do so? If so, can you?

Comment 11

[Kapil Singh [:kapy]]

Yes, I did run it and it runs perfectly. I also downloaded a build with it.
You can see the screenshot.
http://imgur.com/3INQyCv

Thanks,
Kapil

Comment 12

[Kapil Singh [:kapy]]

Hello Will,
I have attached one more screenshot.
http://imgur.com/OvPYu4h

Comment 13

[William Lachance (:wlach)]

Comment on attachment 8511626 [details] [diff] [review]
Adding-support-for-64-bit-Windows-Builds

Review of attachment 8511626 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thank you! Tested it myself and it works great.

Comment 14

[William Lachance (:wlach)]

Pushed: https://github.com/mozilla/mozregression/commit/5e12c3e8af54e495df93e1eb79a75dc824bfaa9a