1129899 - Don't silently use the unsupported x64 builds on 64bit Windows

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Ed Morley [:emorley]]

At present, the 64bit Nightly builds are unsupported, with most users on 64bit Windows still using 32bit binaries.

However mozregression detects it is being run on a 64bit OS and bisects the win64 binaries instead of the win32 ones.

We should either:
1) Default to the 32 bit ones unless |--bits 64| passed, at least until the 64 bit binaries become officially supported
2) Error out unless the user specifies |--bits N| on a 64bit version of Windows, giving them a message that explains they need to choose.

Either way we shouldn't default to a bad choice silently :-)

Comment 1

[Julien Pagès (:parkouss)]

Hm I can see the point. We enabled win 64 build with bug 1085433.

I have a question, when will the 64 bit binaries be officially supported ? Maybe we could let the code as it is if it is soon.

Else I would agree with solution 1) - taking 32 bit as a default on windows and log something to indicate the behaviour if user is on win64. Of course the use of the flag will override this default.

Comment 2

[Ed Morley [:emorley]]

Bug 1085433 definitely was an improvement - since at least mozregression works out of the box on windows x64 without hitting exceptions :-)

I have no idea as to the timeframe of the win64 builds becoming (a) supported, and (b) more widely used than the win32 builds - but perhaps we can simplify the task here and just output a warning/info message on 64bit OSes (both windows and otherwise) rather than anything more involved?

eg:
(mozregression)[~/src]$ mozregression --good 2015-01-01
 0:00.00 LOG: MainThread INFO '--bits {32,64}' not specified, using 64-bit builds.
 0:00.00 LOG: MainThread INFO No 'bad' date specified, using 2015-02-05

Comment 3

[Julien Pagès (:parkouss)]

Works for me. :) Or maybe we could just do this for windows ? OSX is only 64 bits, and I presume Linux users are waiting for 64 bits builds when they are on a 64 bits system, unless specified otherwise.

Either way, a simple log statement seems good here.

Comment 4

[Ed Morley [:emorley]]

(In reply to Julien Pagès from comment #3)
> Works for me. :) Or maybe we could just do this for windows ? 

Yeah agreed - I changed my mind after posting comment 2, but didn't seem worth the bugspam to correct myself :-)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

AFAIK we officially support win64 builds on Nightly and Aurora now. Starting with Firefox 37.b1 they will also be available for our beta audience and later for release. So I think we should keep the behavior.

Comment 6

[Ed Morley [:emorley]]

Comment 2 was suggesting just adding more output not changing the behaviour.

Also, even if they are "official", they are still not used by the vast majority of windows Nightly users at present.

Comment 7

[Utkarsh Bansal]

Hi, i'm interested in fixing this, however I would need help getting around things.

Comment 8

[Julien Pagès (:parkouss)]

Hello Utkarsh,

I'm glad you want to work on this. :)

You can have a look at http://mozilla.github.io/mozregression/contribute.html for a start.
From there you will find plenty of useful links to get started, like:

https://wiki.mozilla.org/Auto-tools/Projects/Mozregression
https://github.com/mozilla/mozregression
http://ateam-bootcamp.readthedocs.org/en/latest/guide/development_process.html#git-and-github

For the issue here, we need to add a log warning when the mozregression command line is used
on windows 64 and that the --bits option is not set (Also, no warning if the --app option is
"fennec" or "fennec-2.3" as we use the same binaries for these).

Note that we just added the support of configuration file, so you have to take care of that.
In other terms, if the bits option is set from the command line OR from the config file,
we don't want a warning to appear.

Let me know if you have any questions!

Comment 9

[Julien Pagès (:parkouss)]

Hey Utkarsh, are you still interested to work on this ?

Comment 10

[Julien Pagès (:parkouss)]

I will assume he's no more interested.

Comment 11

[Julien Pagès (:parkouss)]

Attachment: Warn the window user that he is using 64bit builds

Hey Jonathan, I would like you to do more reviews on mozregression, if you like. :)

By the way, it would be cool now that you seem really involved if you had some more permissions on bugzilla to create bugs, assign them, etc. How does that sound ?

Comment 12

[Julien Pagès (:parkouss)]

Ok jonathan, you should have editbugs rights for bugzilla. :)

Comment 13

[jonathan.pigree]

Hey looks good. Thanks. I will try to make good use of it. :)

Comment 14

[jonathan.pigree]

Reviewed your PR. Looks good to me.

Comment 15

[Julien Pagès (:parkouss)]

Thanks Jonathan. :)

I merged this in.