1086215 - [LockScreen] Resume the animation delay of Bug 1069879 after Bug 1079706 landed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Since Bug 1069879 follows the old way to control the panel animation, which would be eliminated with Bug 1079706, we need to re-implement the method of animation delaying according to the new mechanism.

The reason I don't want to resolve it in Bug 1079706 is Bug 1069879 is a 2.1 blocker with 2 patches for master and 2.1, but the change only happen on master. So I fire this bug to resolve it.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

1. Move the unlocking logic of passcode-enabled unlocking from lockscreen.js to the new Unlock state.

2. Map input-window-close/open events to state transferring, and replace the previous way (state managed) with the events version.

3. Fix the relevant tests.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

The 1. is the major issue we must fix because before this patch, the unlocking logic and its animation is out of states' control, so the animation performs concurrently, and caused the bug.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Gaia-Try is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=25b14214c275

So I would land this patch.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/678fd2281b678e665c1a77eb4d6325a626768679