[LockScreen] Encapsulate passcode pad as a standalone component (with LockScreenInputWindow)

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gweng, Assigned: gweng)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Current LockScreenWindowManager and the old LockScreen manage the passpad directly. This increase the complication between sub-component and its parent. But things may not go well if we encapsulate it as a non-frame component and later we need to change it to use the real keyboard. So I prefer to make a LockScreenInputWindow that implement the interface of the near future InputWindow, so we can invoke real keyboard instead of the keypad and thus complete the encapsulation,  while in the future we don't need to rewrite the whole keypad logic again, but replace the implementation of LockScreenInputWindow to inherit the real InputWindow.
(Assignee)

Comment 1

4 years ago
After we implement the LockScreenInputWindow, we can evolute this with 3 steps:

1. LockScreenInputWindow + current keypad, not the real keyboard yet
2. LockScreenInputWindow + custom keyboard iframe, but not follow the real InputWindow flow
3. LockScreenInputWindow inherit the real InputWindow
Assignee: nobody → gweng
(Assignee)

Updated

4 years ago
Blocks: 1053680
(Assignee)

Comment 2

4 years ago
The major risks: integration and Gaia UI tests.
(Assignee)

Comment 4

4 years ago
Comment on attachment 8503874 [details] [review]
Patch

Set feedback since the patch now works. Left: tests and possible architecture issues.
Attachment #8503874 - Flags: feedback?(alive)
Attachment #8503874 - Flags: feedback?(alive) → feedback+
(Assignee)

Updated

4 years ago
Attachment #8503874 - Flags: review?(alive)
(Assignee)

Comment 5

4 years ago
Update the patch with what you commented. So I set the review.
(Assignee)

Comment 6

4 years ago
Comment on attachment 8503874 [details] [review]
Patch

>https://github.com/mozilla-b2g/gaia/pull/24957
Attachment #8503874 - Attachment description: WIP Patch → Patch
Comment on attachment 8503874 [details] [review]
Patch

r=me
Attachment #8503874 - Flags: review?(alive) → review+
(Assignee)

Updated

4 years ago
Blocks: 1086215
(Assignee)

Comment 8

4 years ago
Gaia-Try is green:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=9f209ebe8e7a

So I would land this patch. Hope In-Bound would keep good, too.
(Assignee)

Comment 9

4 years ago
master: https://github.com/mozilla-b2g/gaia/commit/b62cf59505bfb7eb2076be856827dcaff527c549
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Depends on: 1090018
You need to log in before you can comment on or make changes to this bug.