1086221 - Increase close button hit area in tabs panel

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

In the new tab grid view we need to make the close button hit area bigger as it's currently way too small.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Increase close button hit area in tabs panel

This feels better - do you think posting the runnable is overkill?

Comment 2

[Lucas Rocha (:lucasr)]

Let's see if the hit area is big enough with the new cell layout.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8508595 [details] [diff] [review]
Increase close button hit area in tabs panel

Review of attachment 8508595 [details] [diff] [review]:
-----------------------------------------------------------------

Let's use OnPreDrawListener instead.

::: mobile/android/base/ThumbnailHelper.java
@@ +31,4 @@
>  public final class ThumbnailHelper {
>      private static final String LOGTAG = "GeckoThumbnailHelper";
>  
> +    public static final float THUMBNAIL_ASPECT_RATIO = 1.5f;//0.571f;  // this is a 4:7 ratio (as per UX decision)

Unrelated?

::: mobile/android/base/tabs/TabsLayoutItemView.java
@@ +94,5 @@
> +                final Rect r = new Rect();
> +                mCloseButton.getHitRect(r);
> +                r.left -= 20;
> +                r.bottom += 20;
> +                setTouchDelegate(new TouchDelegate(r, mCloseButton));

Using OnPreDrawListener is a more robust approach. Something like:

getViewTreeObserver().addOnPreDrawListener(new OnPreDrawListener() {
    @Override
    public boolean onPreDraw() {
        getViewTreeObserver().removeOnPreDrawListener(this);

        final Rect r = new Rect();
        mCloseButton.getHitRect(r);
        r.left -= 20;	
        r.bottom += 20;
	
        setTouchDelegate(new TouchDelegate(r, mCloseButton));
    }
});

Comment 4

[Martyn Haigh (:mhaigh)]

Attachment: Increase close button hit area in tabs panel

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8516685 [details] [diff] [review]
Increase close button hit area in tabs panel

Review of attachment 8516685 [details] [diff] [review]:
-----------------------------------------------------------------

Great.

Comment 6

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/336e63f959ef

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/336e63f959ef