1086260 - [Contacts] Wrong message opening contact list (pick activity) if no contacts are stored in the device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Javier de Prado]

Attachment: 2014-10-21-13-14-11.png

Tested on flame (Gecko-b3429ef.Gaia-c6c6116) and fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965
English and Spanish.

STR:
1.- Clear contact list.
2.- Open loop app and push the icon to open contact list.

ACTUAL RESULT: (see attachment) Message "Cannot add to contact as your contact list is empty"
EXPECTED RESULT: Something like "Your contact list is empty"

Comment 1

[Maria Angeles Oteo (:oteo)]

We are showing a message from FxOS, as we are delegating to the OS the pick activity handling so I don't think it could have a simple solution... Anyway, setting ni to Borja to conform it.

Besides we are already in string freeze so no more string changes should be included for v1.1 branch.

Comment 2

[Cristian Rodriguez (:crdlc)]

Nothing to do here from our side, it lives in contacts app and it shows this message. Although we can know if the contact list is empty and could show the correct message instead of contacts app. But :) I don't know if the issue about Moz contacts permissions was fixed or not. And also, we cannot add new strings at that moment. Then sadly I can say that this won't be fixed for Loop, at least for version 1.1

Comment 3

[Maria Angeles Oteo (:oteo)]

Thanks a lot JM for taking care of this!

Comment 4

[Jose Manuel Cantera]

As per bug 1087979 comment 5 we will need a new visual design in order to address this use case.

Comment 5

[Carrie Wang [New account: [e-mail]]]

This bug is depending on bug 1087979. I'm waiting for the string suggestion (need to unify the string with other APP pickers) and Carol will provide the icon template for each APP so that Fang can work on Contact's one. Thanks!

Comment 6

[Fang Shih [:fang]]

I'll work on the design once Carol provide the template. Thanks!

Comment 8

[Jose Manuel Cantera]

Fang,

Any news about this bug. It's been a long time since it was opened

thanks

Comment 9

[Carrie Wang [New account: [e-mail]]]

Hi, 

I recheck this bug and figure out that for the Loop case, we can simply display a confirm window which shows "No contacts in the contact list". We couldn't change the string because the string was freeze at that time. Can we fix it now?

Fang is working on the icon for "no contacts" in Contacts APP and it's not related to this bug. 

Thanks!

Comment 10

[Jose Manuel Cantera]

Attachment: GH PR

only L10N changes

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8548039 [details] [review]
GH PR

Tiny, tiny nit, looking good.

Comment 12

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/78c37d1c5396613b6f5cfbdce6e28d01e80b406d

Comment 13

[Jose Manuel Cantera]

Comment on attachment 8548039 [details] [review]
GH PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Incorrect message shown to the user when no contacts present in the contacts list
[User impact] if declined: Medium, inconsistent app will be perceived
[Testing completed]: Yes 
[Risk to taking this patch] (and alternatives if risky): No risk patch
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/27346/files#diff-a8e39eba575534c9d35a2b692b6550e1R28

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/88e0235f6a956b6b93f34fe9fe200b2e4b291c36

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v2.2 by the STR in Comment 0.

Actual results: Pushing the icon to open contact list in Loop, it prompts "No contacts in your Contacts list" as expected.
See attachment: verified_v2.2.png
Reproduce rate: 0/10


Device: Flame v2.2 (verified) 
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.200238
Firmware Date          Tue Jun 30 20:02:49 EDT 2015
Bootloader             L1TC000118D0


Note:
I am unable to log in the account successfully in Loop on latest Flame master, then I can verify this bug.

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.png

Note:
Loop version is "1.1.1d".

Comment 17

[Maria Angeles Oteo (:oteo)]

(In reply to Shally from comment #15)

> I am unable to log in the account successfully in Loop on latest Flame
> master, then I can verify this bug.

That issue was reported in Bug 1168173 - Flame: Cannot authenticate using Firefox account

Comment 18

[Shally Li（leave from Mozilla）]

According to "https://bugzilla.mozilla.org/show_bug.cgi?id=1168173#c8", it is 'WON'T FIX' since we're not supporting the Hello Firefox OS application anymore, so change status to "verified".