1086663 - "Built from revision X" and other TinderboxPrints don't appear on Treeherder

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P2)

Description

[Joshua Cranmer [:jcranmer]]

Most importantly, we're missing the following lines:
TinderboxPrint:moz: 29fbfc1b31aa
TinderboxPrint:ldap: 2b72c62f5450

Compare <https://tbpl.mozilla.org/?tree=Thunderbird-Trunk> with <https://treeherder.mozilla.org/ui/#/jobs?repo=comm-central>.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing this :-)

Comment 2

[Ed Morley [:emorley]]

It's because there is no space after TinderboxPrint, eg:

TinderboxPrint:<a href=https://hg.mozilla.org/mozilla-central/rev/cc1cfd6f4ca8 title='Built from mozilla-central revision cc1cfd6f4ca8'>moz:cc1cfd6f4ca8</a>

And the regex is:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/parsers.pyx#L191
RE_TINDERBOXPRINT = re.compile('.*TinderboxPrint: (?P<line>.*)$')

I'd say comm-central should fix this, but we'll probably end up playing whac-a-mole, so let's just make the regex a bit more flexible for now, and push forwards on getting rid of TinderboxPrint entirely in the medium term.

Comment 3

[Ed Morley [:emorley]]

Attachment: Make the TinderboxPrint regex less strict about whitespace

So that we don't miss TinderboxPrints from comm-central and Jetpack.

Comment 4

[Ed Morley [:emorley]]

In fact, this isn't limited to comm-central:
http://mxr.mozilla.org/build-central/source/tools/buildfarm/utils/printbuildrev.py#31

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8550460 [details] [review]
Make the TinderboxPrint regex less strict about whitespace

lgtm!

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/9350fc3368b0a8d2a32db1bc644c251ae5fc72c8
Bug 1086663 - Make the TinderboxPrint regex less strict about whitespace

So that we don't miss "Built from revision X" and other TinderboxPrints.

Comment 7

[Ed Morley [:emorley]]

This should be in production Mon/Tues next week :-)

Comment 8

[Ed Morley [:emorley]]

In production :-)