Closed Bug 1086687 Opened 5 years ago Closed 5 years ago

Write an automated test for "Unlink a previously linked Facebook contact from contact details" moztrap smoketest

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

()

Details

Attachments

(1 file, 2 obsolete files)

This is https://moztrap.mozilla.org/manage/case/5858/
Verify that contact unlinking from facebook profile works.
PRE-REQ:

Have some contacts in the address book with facebook profiles linked to them.

    Open the Contacts app.

    Select one of the contacts with a Facebook profile linked.

    The contact selected is displayed with all its details

    Tap the "Unlink" contact button.

    Tap the Unlink button in the confirmation dialog.

    The contact is updated and facebook information is deleted from the contact, Facebook icon is removed from contact details and contact register in address book. Now there are two contacts: one normal and the unlinked facebook contact
Looks like we're adding a new Gaia UI Test. If not, please move back this bug in the Gaia::Contacts component.
Component: Gaia::Contacts → Gaia::UI Tests
QA Whiteboard: fxosqa-auto-s3, fxosqa-auto-points=8, fxosqa-auto-from-s2
Flags: in-qa-testsuite?(martijn.martijn)
QA Whiteboard: fxosqa-auto-s3, fxosqa-auto-points=8, fxosqa-auto-from-s2 → fxosqa-auto-s3, fxosqa-auto-points=8,
Attached patch unlink_facebook.diff (obsolete) — Splinter Review
I'm attaching the work that I've done so far, as a diff here.
This depends on the work on bug 1086680, and I already made changes there, so this patch has to be reworked.
Depends on: 1086680
QA Whiteboard: fxosqa-auto-s3, fxosqa-auto-points=8, → fxosqa-auto-dropped-s3, fxosqa-auto-points=8, fxosqa-auto-backlog+
QA Whiteboard: fxosqa-auto-dropped-s3, fxosqa-auto-points=8, fxosqa-auto-backlog+ → fxosqa-auto-from-s2, fxosqa-auto-dropped-s3, fxosqa-auto-points=8, fxosqa-auto-backlog+
Attached file facebook_unlink (obsolete) —
This is on top of the pull request from bug 1086680.
Attachment #8516766 - Attachment is obsolete: true
Attached file facebook_unlink2
This is with the facebook.py move to the system app as was discussed in the pull request as part of bug 1112334.
Attachment #8541887 - Attachment is obsolete: true
Attachment #8542632 - Flags: review?(robert.chira)
Attachment #8542632 - Flags: review?(jlorenzo)
Comment on attachment 8542632 [details] [review]
facebook_unlink2

Comments in the PR
Attachment #8542632 - Flags: review?(robert.chira) → review-
Comment on attachment 8542632 [details] [review]
facebook_unlink2

The test is working on my device. I think we can be more precise with the locators before including the test in our code base.
Attachment #8542632 - Flags: review?(jlorenzo) → review-
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #6) 
> The test is working on my device. I think we can be more precise with the
> locators before including the test in our code base.

One of your suggested locators didn't work, so I kept the old one.
Sorry, I had some major errors in the pull request, which I should have noticed before asking review.
Kicked of a Jenkins test run now on my updated pull request: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/529/
Depends on: 1116758
Comment on attachment 8542632 [details] [review]
facebook_unlink2

Jenkins adhoc run all passed.
Attachment #8542632 - Flags: review?(robert.chira)
Attachment #8542632 - Flags: review?(jlorenzo)
Attachment #8542632 - Flags: review-
Comment on attachment 8542632 [details] [review]
facebook_unlink2

I found the reason why we can't use the ID in this test, it's an actual bug (see bug 1116758). We should leave the bug number as a comment.

A couple of small nits remain.

After that, I don't see anything else blocking.
Attachment #8542632 - Flags: review?(jlorenzo) → review-
Comment on attachment 8542632 [details] [review]
facebook_unlink2

Updated pull request with review comments.
Attachment #8542632 - Flags: review- → review?(jlorenzo)
Comment on attachment 8542632 [details] [review]
facebook_unlink2

LGTM!
Attachment #8542632 - Flags: review?(jlorenzo) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-dropped-s3, fxosqa-auto-points=8, fxosqa-auto-backlog+ → fxosqa-auto-from-s2, fxosqa-auto-dropped-s3, fxosqa-auto-points=8, [fxosqa-auto-s7][fxosqa-auto-points=2]
Flags: in-qa-testsuite?(martijn.martijn) → in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.