1086687 - Write an automated test for "Unlink a previously linked Facebook contact from contact details" moztrap smoketest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

This is https://moztrap.mozilla.org/manage/case/5858/
Verify that contact unlinking from facebook profile works.
PRE-REQ:

Have some contacts in the address book with facebook profiles linked to them.

    Open the Contacts app.

    Select one of the contacts with a Facebook profile linked.

    The contact selected is displayed with all its details

    Tap the "Unlink" contact button.

    Tap the Unlink button in the confirmation dialog.

    The contact is updated and facebook information is deleted from the contact, Facebook icon is removed from contact details and contact register in address book. Now there are two contacts: one normal and the unlinked facebook contact

Comment 1

[Johan Lorenzo [:jlorenzo]]

Looks like we're adding a new Gaia UI Test. If not, please move back this bug in the Gaia::Contacts component.

Comment 2

[Martijn Wargers (dead)]

Attachment: unlink_facebook.diff

I'm attaching the work that I've done so far, as a diff here.
This depends on the work on bug 1086680, and I already made changes there, so this patch has to be reworked.

Comment 3

[Martijn Wargers (dead)]

Attachment: facebook_unlink

This is on top of the pull request from bug 1086680.

Comment 4

[Martijn Wargers (dead)]

Attachment: facebook_unlink2

This is with the facebook.py move to the system app as was discussed in the pull request as part of bug 1112334.

Comment 5

[Robert Chira [:RobertC]]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

Comments in the PR

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

The test is working on my device. I think we can be more precise with the locators before including the test in our code base.

Comment 7

[Martijn Wargers (dead)]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #6) 
> The test is working on my device. I think we can be more precise with the
> locators before including the test in our code base.

One of your suggested locators didn't work, so I kept the old one.
Sorry, I had some major errors in the pull request, which I should have noticed before asking review.
Kicked of a Jenkins test run now on my updated pull request: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/529/

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

Jenkins adhoc run all passed.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

I found the reason why we can't use the ID in this test, it's an actual bug (see bug 1116758). We should leave the bug number as a comment.

A couple of small nits remain.

After that, I don't see anything else blocking.

Comment 10

[Martijn Wargers (dead)]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

Updated pull request with review comments.

Comment 11

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

LGTM!

Comment 12

[Robert Chira [:RobertC]]

Comment on attachment 8542632 [details] [review]
facebook_unlink2

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/76ba1d102b7c17a515ce546cab375f6d4ec0b6f7