All users were logged out of Bugzilla on October 13th, 2018

[Loop][Server] We should store the user ID if no "issuer" is provided for POST /call-url

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ferjm, Assigned: ferjm)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
According to [1] the "issuer" parameter allows Loop clients to specify a friendly name of the issuer of the call URL, but so far none of the Loop clients is allowing the user to enter this friendly name. And even if we could allow it from the clients at some point, the user might choose not to specify a friendly name. In this case, we should use the user identity to fill this value if possible. Otherwise, the caller won't see the information about who is she calling on the Loop client UI cause the value of "calleeFriendlyName" from [2] won't be set.

[1] https://docs.services.mozilla.com/loop/apis.html#post-call-url
[2] https://docs.services.mozilla.com/loop/apis.html#get-calls-token
(Assignee)

Updated

4 years ago
Component: Gaia::Loop → Server
Product: Firefox OS → Loop
(Assignee)

Updated

4 years ago
Assignee: nobody → ferjmoreno
(Assignee)

Comment 1

4 years ago
Created attachment 8508832 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/230

I'll be adding some tests tomorrow
Whiteboard: [qa+]
Comment on attachment 8508832 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/230

Hey fernando,

This works pretty well but needs to have tests in order for us to merge it :)

thanks!
Attachment #8508832 - Flags: review-
>  I'll be adding some tests tomorrow
Oh, just seen your comment, sorry! I'll let you add them, please r? me when this is done.
Flags: needinfo?(ferjmoreno)
Attachment #8508832 - Flags: review-
(Assignee)

Comment 4

4 years ago
Comment on attachment 8508832 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/230

Thanks Alexis. Yeah, I had to write the tests :) sorry for the late. I've just updated the PR. It seems that Travis failed, but the error doesn't seem related to the patch. I can't retrigger the job though.
Flags: needinfo?(ferjmoreno)
Attachment #8508832 - Flags: review?(alexis+bugs)
Comment on attachment 8508832 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/230

I've added a few nitpicks, but besides that it looks great. I'll review again once the extra test is added and we don't set the issuer if it's not provided.
Attachment #8508832 - Flags: review?(alexis+bugs)
(Assignee)

Comment 6

4 years ago
Comment on attachment 8508832 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/loop-server/pull/230

Done. Thank you Alexis!
Attachment #8508832 - Flags: review?(alexis+bugs)
Thanks Fernando!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Alexis, in this patch already in development server "https://loop-dev.stage.mozaws.net"?
Flags: needinfo?(alexis+bugs)
It wasn't. I've deployed it now.
Flags: needinfo?(alexis+bugs)
Blocks: 1084353
No longer depends on: 1084353
I am still seeing the issue pointing to Dev Server...

Updated

4 years ago
Depends on: 1090306
Blocks: 1090306
No longer depends on: 1090306
Reopening since Maria is still seeing the issue...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry for the inconvenience, I've retested it again and I think server is working fine, in fact I can see that the user ID/contact name is kept in the call log of the device that clicks on a received shared URL. 

I was wrong because I saw that the the call screen was not showing the ID/contact name but it seems a client issue.

So resolving the bug again.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
OK. Marking Verified before you change your mind. ;-)
Thanks for retesting this Maria!
Status: RESOLVED → VERIFIED
Blocks: 1090849
(In reply to James Bonacci [:jbonacci] from comment #14)
> OK. Marking Verified before you change your mind. ;-)
> Thanks for retesting this Maria!

hahah,

James, do you know when this patch is planned to be in Production server?
Thanks a lot!
Flags: needinfo?(jbonacci)
This could go into the next release (next week).
Not sure if we will have a 0.12.6 or a 0.13.0.
Holding at Resolved/Fixed until this does, indeed, get into Production.
Somehow I misread Dev and Production...
Status: VERIFIED → RESOLVED
Last Resolved: 4 years ago4 years ago
Flags: needinfo?(jbonacci)
We might want to backport this change to the 0.12.X branch since it's a bugfix. 0.13 will be rooms.
As sooner the better
You need to log in before you can comment on or make changes to this bug.