1090849 - [Loop] I can't see the ID of the contact in the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Maria Angeles Oteo (:oteo)]

This bug is opened to complete the scenario already reported in bug 1084353(sever patch bug 1086698). See also https://bugzilla.mozilla.org/show_bug.cgi?id=1084353#c8

Although with patch in bug 1086698, the A contact name is already shown in the call log of device B, we continue NOT seeing that in the call screen of Device B when the call is established (before hanging up).

Our loop mobile client is not ready to handle/show the contact name/ID in the call screen for this type of call that come from a clicked URL and we should try to address this issue.

Be aware that 1086698 is still in development server.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

thanks José

Comment 2

[Maria Angeles Oteo (:oteo)]

approval given, so when the patch can be landed in master and 1.1 branch at the same time

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8513365 [details]
Github pull request

LGTM. r=me

Thanks for taking care of this!

Comment 4

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/7e490c5f0ea7940f1841b9008b486776394bf11c

Comment 5

[Cristian Rodriguez (:crdlc)]

in 1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5eab37e25e949cdab27215b9f4b1de8c147c7478

Comment 6

[Loli (:lolimartinezcr)]

Attachment: 20141105_171045.jpg

Comment 7

[Maria Angeles Oteo (:oteo)]

This bug can not be verified until server bug 1086698 is on Production (ETA 5th November, but it seems that it's delayed)

Comment 8

[Javier de Prado]

Verified on Flame & FireE, loop version 1.1: 2e7c3c2
It's running fine and the the contact name/ID is shown in the call screen.