[Loop] I can't see the ID of the contact in the Call screen when I call, via browser, from a link shared by that contact in a SMS/e-mail

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: oteo, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][blocking][tef-triage][loop approved for 1.1][loop in 1.1])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
This bug is opened to complete the scenario already reported in bug 1084353(sever patch bug 1086698). See also https://bugzilla.mozilla.org/show_bug.cgi?id=1084353#c8

Although with patch in bug 1086698, the A contact name is already shown in the call log of device B, we continue NOT seeing that in the call screen of Device B when the call is established (before hanging up).

Our loop mobile client is not ready to handle/show the contact name/ID in the call screen for this type of call that come from a clicked URL and we should try to address this issue.

Be aware that 1086698 is still in development server.
(Reporter)

Updated

4 years ago
Assignee: nobody → crdlc
Blocks: 1036490
Severity: normal → major
Status: NEW → ASSIGNED
Whiteboard: [mobile app][blocking][tef-triage]
(Reporter)

Updated

4 years ago
Depends on: 1086698
(Assignee)

Comment 1

4 years ago
Created attachment 8513365 [details]
Github pull request

thanks José
Attachment #8513365 - Flags: review?(josea.olivera)
(Reporter)

Comment 2

4 years ago
approval given, so when the patch can be landed in master and 1.1 branch at the same time
Whiteboard: [mobile app][blocking][tef-triage] → [mobile app][blocking][tef-triage][loop approved for 1.1]
Comment on attachment 8513365 [details]
Github pull request

LGTM. r=me

Thanks for taking care of this!
Attachment #8513365 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 4

4 years ago
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/7e490c5f0ea7940f1841b9008b486776394bf11c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

4 years ago
in 1.1:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5eab37e25e949cdab27215b9f4b1de8c147c7478
Whiteboard: [mobile app][blocking][tef-triage][loop approved for 1.1] → [mobile app][blocking][tef-triage][loop approved for 1.1][loop in 1.1]
Created attachment 8517506 [details]
20141105_171045.jpg
(Reporter)

Comment 7

4 years ago
This bug can not be verified until server bug 1086698 is on Production (ETA 5th November, but it seems that it's delayed)

Comment 8

4 years ago
Verified on Flame & FireE, loop version 1.1: 2e7c3c2
It's running fine and the the contact name/ID is shown in the call screen.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.