1087026 - [2.1][l10n][cost control] Multiple locales: the line "use data alert" is overlapped by the toggle switch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[[:RJ]]

Attachment: Image of issue

Description:
In Albanian the line "use data alert" is overlapped by the toggle switch 

Repro Steps:
1) Update a Flame to 20141020001201
2) Go to usage app
3) tap through the FTU screens till usa data alert string is on screen 


Actual:
Text is is overlapped by the toggle switch 


Expected:
text displays correctly 

Environmental Variables:
Device: Flame 2.1
Build ID: 20141021001201
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Gecko: ee86921a986f
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency:100%
See attached: screenshot

Comment 1

[[:RJ]]

Issue does not occur in the flame 2.0 
No overlap occurs
flame 2.0 (319mb)(Kitkat Base)(Full Flash)

Environmental Variables:
Device: Flame 2.0
Build ID: 20141021000201
Gaia: 63b56a7a7453726b9e12ad1afe02c68c83c5aeca
Gecko: 40584eecdc75
Version: 32.0 (2.0)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:
Albanian is a critical Tako shipping locale
This is a regression
Flagging UX

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: blocking per comment 2

Comment 6

[Paco Rampas [:paco]]

Attachment: switches-with-long-text.png

Comment 7

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8509345 [details] [review]
patch in github

Looks good. Thanks Paco!

Comment 10

[Stephany Wilkes]

Removing flag; patch looks good.

Comment 11

[Jordi Serratosa]

Does this this bug refer to the string in the FTU app specifically?
Please note that the same overlapping occurs within the Usage app itself.
Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1087067 deals with the string in the Usage app. It was marked as duplicate of this one.
If this bug does not fix the string in both locations, then Malayan bug is not a duplicate of this.

Comment 12

[Paco Rampas [:paco]]

(In reply to Jordi Serratosa from comment #11)
> Does this this bug refer to the string in the FTU app specifically?
I think that bug is a duplicate. This patch should fix both scenarios.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Hi Paco,

do you need someone to push this bug and mark it as fixed?

Comment 15

[Paco Rampas [:paco]]

> do you need someone to push this bug and mark it as fixed?
There are two issues in gaia-try, I am going to rebase the patch for reloading. If I have any problem I will let you know. Thanks ;)

Comment 16

[Paco Rampas [:paco]]

merged: d65835dc7d554df0a6a88ba3321f33578af36e88

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please request v2.1 approval on this when you get a chance.

Comment 18

[Paco Rampas [:paco]]

Comment on attachment 8509345 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): new BB feature
[User impact] if declined: wrong visualization
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/7194e297dae41aea44ad78b8c58f81ec3b760d62

Comment 20

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: The string is wrapped instead of being overlapped by the toggle. Checked with the following languages: 
Brazilian Portuguese, Albanian, Basque, Galician, Greek, Hungarian, Polish,  Serbian Cyrillic, Serbian Latin, Turkish, Danish, Swedish, Spanish, Bengali from India, Croatian, Macedonian, Hindi, Afrikaans, Zulu, Catalan, Czech, Russian, Slovak, Malay, Dutch, Bulgarian, Romanian, Indonesian, Xhosa

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141103001220
Gaia: 027a7de0c95320cea0579bfd1a4ceef3e9038f34
Gecko: ffecb2be228b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141103040202
Gaia: bc168c17474dabbcceaa349e9bc7c95654435aec
Gecko: 5999e92e89ff
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0