Closed
Bug 1087086
Opened 10 years ago
Closed 7 years ago
SeaMonkey Windows builders are creating nested mozilla/ folders in the objdir.
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(3 files)
16.13 KB,
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
1.01 KB,
patch
|
Details | Diff | Splinter Review | |
656 bytes,
patch
|
Details | Diff | Splinter Review |
This is the main reason why our Windows builders are having so hard a time clobbering. There's a nested "mozilla" dir in the ./objdir that's nested about 15+ levels deep. I had to go in and enter the nested mozilla dir and delete it manually. Filing this bug to track what's creating the nested mozilla folder.
Assignee | ||
Comment 1•10 years ago
|
||
Callek (over irc) mentioned that our clobberer.py needs updating and we probably can use the default's clobberer.py.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8529355 -
Flags: review?(bugspam.Callek)
(In reply to Edmund Wong (:ewong) from comment #2) > Created attachment 8529355 [details] [diff] [review] > clobberer.py patch. For review purposes is worth supplying a non-whitespace change version of the patch?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Ian Neal from comment #3) > (In reply to Edmund Wong (:ewong) from comment #2) > > Created attachment 8529355 [details] [diff] [review] > > clobberer.py patch. > > For review purposes is worth supplying a non-whitespace change version of > the patch? Sorry. I don't understand what you mean. (Can't seem to wrap my head around that.)
Comment 5•10 years ago
|
||
Comment on attachment 8529355 [details] [diff] [review] clobberer.py patch. Review of attachment 8529355 [details] [diff] [review]: ----------------------------------------------------------------- this is actually a 1:1 version of the upstream clobber client. Which has had autopep8 applied to it while our has not. The changes upstream look good and bear no issues for seamonkey specific automation (that I know of)
Attachment #8529355 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8529416 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8649081 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8649081 [details] [diff] [review] use proper env for update_verify_factory (v1) Pushed to buildbot-configs: http://hg.mozilla.org/build/buildbot-configs/rev/4df180b7f455
Assignee | ||
Updated•7 years ago
|
Attachment #8529416 -
Flags: review?(bugspam.Callek)
Assignee | ||
Updated•7 years ago
|
Attachment #8649081 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 9•7 years ago
|
||
Fixed in bug 1072713
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•