1087086 - SeaMonkey Windows builders are creating nested mozilla/ folders in the objdir.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

This is the main reason why our Windows builders are  having so hard a time
clobbering.  

There's a nested "mozilla" dir in the ./objdir that's nested about 15+ levels
deep. I had to go in and enter the nested mozilla dir and delete it manually.

Filing this bug to track what's creating the nested mozilla folder.

Comment 1

[Edmund Wong (:ewong)]

Callek (over irc) mentioned that our clobberer.py needs updating and
we probably can use the default's clobberer.py.

Comment 2

[Edmund Wong (:ewong)]

Attachment: clobberer.py patch.

Comment 3

[Ian Neal]

(In reply to Edmund Wong (:ewong) from comment #2)
> Created attachment 8529355 [details] [diff] [review]
> clobberer.py patch.

For review purposes is worth supplying a non-whitespace change version of the patch?

Comment 4

[Edmund Wong (:ewong)]

(In reply to Ian Neal from comment #3)
> (In reply to Edmund Wong (:ewong) from comment #2)
> > Created attachment 8529355 [details] [diff] [review]
> > clobberer.py patch.
> 
> For review purposes is worth supplying a non-whitespace change version of
> the patch?

Sorry.  I don't understand what you mean. (Can't seem to wrap my head around
that.)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8529355 [details] [diff] [review]
clobberer.py patch.

Review of attachment 8529355 [details] [diff] [review]:
-----------------------------------------------------------------

this is actually a 1:1 version of the upstream clobber client. Which has had autopep8 applied to it while our has not. The changes upstream look good and bear no issues for seamonkey specific automation (that I know of)

Comment 6

[Edmund Wong (:ewong)]

Attachment: use proper env in the clobber step.

Comment 7

[Edmund Wong (:ewong)]

Attachment: use proper env for update_verify_factory (v1)

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8649081 [details] [diff] [review]
use proper env for update_verify_factory (v1)

Pushed to buildbot-configs:
http://hg.mozilla.org/build/buildbot-configs/rev/4df180b7f455

Comment 9

[Edmund Wong (:ewong)]

Fixed in bug 1072713