1087089 - OSX64 Repacks failing during 2.31b1 build.

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

Getting a traceback during the MacOSX64 Repacks:

Packaging seamonkey.xpi...
if test -d "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey"; then cd /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey/; /usr/bin/zip -r9mX ../seamonkey.xpi * -x \*/.mkdir.done; cd ..; rm -rf /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey; fi
Packaging seamonkey-bin.xpi...
if test -d "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey-bin"; then cd /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey-bin/; /usr/bin/zip -r9mX ../seamonkey-bin.xpi * -x \*/.mkdir.done; cd ..; rm -rf /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/seamonkey-bin; fi
Packaging updater.app.xpi...
if test -d "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/updater.app"; then cd /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/updater.app/; /usr/bin/zip -r9mX ../updater.app.xpi * -x \*/.mkdir.done; cd ..; rm -rf /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS/updater.app; fi
  adding: Contents/ (stored 0%)
  adding: Contents/Info.plist (deflated 59%)
  adding: Contents/MacOS/ (stored 0%)
  adding: Contents/MacOS/updater (deflated 59%)
  adding: Contents/PkgInfo (stored 0%)
  adding: Contents/Resources/ (stored 0%)
  adding: Contents/Resources/English.lproj/ (stored 0%)
  adding: Contents/Resources/English.lproj/InfoPlist.strings (deflated 49%)
  adding: Contents/Resources/English.lproj/MainMenu.nib/ (stored 0%)
  adding: Contents/Resources/English.lproj/MainMenu.nib/classes.nib (deflated 49%)
  adding: Contents/Resources/English.lproj/MainMenu.nib/info.nib (deflated 46%)
  adding: Contents/Resources/English.lproj/MainMenu.nib/keyedobjects.nib (deflated 30%)
  adding: Contents/Resources/updater.icns (deflated 45%)
/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/_virtualenv/bin/python /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/mozilla/toolkit/mozapps/installer/l10n-repack.py /builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/obj-l10n/dist/l10n-stage/SeaMonkey/SeaMonkey.app/Contents/MacOS ../../dist/xpi-stage/locale-zh-TW \
		--non-resource defaults/messenger/mailViews.dat defaults/profile/panels.rdf defaults/profile/mimeTypes.rdf defaults/profile/chrome/userChrome-example.css defaults/profile/chrome/userContent-example.css 
Traceback (most recent call last):
  File "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/mozilla/toolkit/mozapps/installer/l10n-repack.py", line 48, in <module>
    main()
  File "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/mozilla/toolkit/mozapps/installer/l10n-repack.py", line 44, in main
    l10n.repack(args.build, args.l10n, args.non_resource, NON_CHROME)
  File "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/mozilla/python/mozbuild/mozpack/packager/l10n.py", line 172, in repack
    _repack(app_finder, l10n_finder, copier, formatter, non_chrome)
  File "/builds/slave/rel-c-beta-osx64-rpk/build/comm-beta/mozilla/python/mozbuild/mozpack/packager/l10n.py", line 63, in _repack
    locale = app.locales[0]
IndexError: list index out of range
make[1]: *** [repackage-zip] Error 1
make: *** [repackage-zip-zh-TW] Error 2

atm, no clue what's going on right now.

Comment 1

[Ian Neal]

Is the fix from bug 1084578 worth looking at for this?

Comment 2

[Justin Wood (:Callek)]

Attachment: [comm-beta] fixes

Will take the review of whomever feels most comfortable here.

This does a few things, but all of them were needed.

the pack-ext stuff was causing all directories in Resources/ to be turned into an xpi on us, the @AB@ was from another bug (https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1084578&attachment=8507565)

And the STAGEDIST stuff was defining things incorrectly while the var is properly defined in the toolkit makefile we include here.

Comment 3

[Justin Wood (:Callek)]

Attachment: [comm-beta] fixes

whops forgot to qref

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8509247 [details] [diff] [review]
[comm-beta] fixes

https://hg.mozilla.org/releases/comm-beta/rev/7e5f0a461d01
https://hg.mozilla.org/releases/comm-beta/rev/6b577fb74d98
https://hg.mozilla.org/releases/comm-aurora/rev/6c3e74ff624e
https://hg.mozilla.org/comm-central/rev/d537e95ba983

Comment 5

[Edmund Wong (:ewong)]

Comment on attachment 8509247 [details] [diff] [review]
[comm-beta] fixes

Review of attachment 8509247 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work, but since glandium already did the review, I think both IanN's and mine review aren't needed (?). I'm at least removing mine.

Comment 6

[Edmund Wong (:ewong)]

this is fixed.