1087195 - [Bluetooth] Add support for HFP, A2DP and AVRCP to Bluetooth daemon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

HFP support includes Gecko and daemon side.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree for bluetoothd

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8509490 [details]
Github tree for bluetoothd

Updated Github tree:

  - send parameters of VOLUME_CMD_NTF as 8-bit values

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The remaining code for all our current profiles is not that much. So let's land this at once.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

The patch set contains support for the remaining profiles: HFP, A2DP, and AVRCP.

Comment 7

[Michael Vines [:m1] [:evilmachines]]

There have been HAL changes for L that affect these profiles.  Please see bug 1102703.  Can we make the changes necessary for L as a part of fixing bug as well?

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I'd like to not break up the patch set if possible, but support for L is on top of my list. Things seem to go slowly recently; I hope we can speed up landing a bit.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8528333 [details]
Github pull request

Updated pull request:

  - fixed a bug where the daemon was quit

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #8)
> I'd like to not break up the patch set if possible, but support for L is on
> top of my list. Things seem to go slowly recently; I hope we can speed up
> landing a bit.
After checking hfp/avrcp code serval times, i think we're good to land these patches. I noticed that AVRCP NTF opcode is different from ANDROID 18 to ANDROID 20 and that needs to added in patch [02] bug 1095488.

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8528333 [details]
Github pull request

Updated pull request

  - added asserts
  - fixed assertions in bt-hf.c that tested for btsock_interface

I built this patch set on flame-kk, nexus-4, and flatfish.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot, Shawn!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/288db53ad77084bd44791add5e3a4c266a6e9c60