1087200 - Behavior is not consistent while playing music and ringtones

Status: RESOLVED DUPLICATE of bug 1043762

(Firefox OS Graveyard :: AudioChannel, defect, P1)

Description

[vasanth]

[Blocking Requested - why for this release]:

Steps to reproduce:
--------------------------
1.Start playback by launching the music app
2.Now navigate to settings->sound->ringtones and start playing a ring tone.
3.Playback is stopped and ringtone is heard
4.Now go back to Menu->music app. Music playback starts again
5.Then come back to Settings->sound->ringtones
6.Observe that audio playback and ringtone both heard on device

#3 and #6 are not consistent.

Please confirm if this is an issue?

Also we really need some doc to know the expected behaviors in cases like this?

There are different sounds (music, voice call, ringtones etc.,) and different devices (headset, handset, speaker etc.,) where any sound can be started in any order and doc should state expected behavior in each case.

We see the FFOS audio channel behavior is different in some cases when compared to Android, so we can't use Android audio channel docs here.

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

On step 5, if it leaves "Select Sound" menu and re-enter again, 
The music/ringtone audio sound won't mix.

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Alive, 
What's different on the step 5:
"Select Sound" just show up or re-enter again?

Comment 3

[Andrew Overholt [:overholt]]

QA, has this happened on previous releases?

2.1 CC blocker = 2.1+

Comment 4

[Cody Roesch [:croesch]]

It's really to reproduce this doing the following.
1. Launch both music app and Settings app.
2. Play some music the hold the home button to go to card view.
3. Switch to Settings and play a ringtone.
4. Hold home to go back to card view and music will automatically play again
5. Tap on the Settings card and play a ring tone.

Results: Both instances of audio will play at the same time.



Tested with Full Flash on 319mb using Engineering builds

This bug repro's on Flame KK builds: Flame 2.1 KK, Flame 2.0 KK, Flame 2.0 Base

Actual Results: Able to get the music to play over ringtone audio.

Repro Rate: 6/6

Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20141022081833
Gaia: 734d3547fb6c65e8bc4dd1a52b26f70bdfee7474
Gecko: 9646e94a041c
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 KK
BuildID: 20141022081832
Gaia: ec722129a962704fda0dd5f39e7efd01261ae946
Gecko: 52280df0e39f
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0 Base
BuildID: 20141016183911
Gaia: 8c5c956ee6909408e29f375cc7d843a03d92f3d8
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.2 KK

Actual Result: Audio channels correctly switch when playing music then playing ringtones.

Repro Rate: 0/5

Environmental Variables:
Device: Flame 2.2 KK
BuildID: 20141021230530
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Transfer ni to Dominic!

Comment 6

[StevenLee[:slee]]

Hi Bobby,
I think Randy is looking this bug or do you need any help from me?

Comment 7

[bhavana bajaj [:bajaj]]

Randy,

Assigning this to you as you are helping with investigation here. Can you please share an eta here given we have to resolve CAF issues blocking CS in the next few days...

Comment 8

[Bobby Chien]

(In reply to StevenLee[:slee] from comment #6)
> Hi Bobby,
> I think Randy is looking this bug or do you need any help from me?

Steven, just a reminder that we should take this. I will ask Dominic for evaluation. thanks.

Comment 9

[Ken Chang[:kenkai]]

Randy, Any update? Could you directly discuss this issue with Dominic? Thanks

Comment 10

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Dominic, 
Please help to check this, thanks a lot.

Comment 11

[Dominic Kuo [:dkuo]]

This is probably another regression(bug 1086280 comment 7) that caused by the new window management from v2.0. Before v2.0, the system app used to close the inline activity window(here is the ringtone pick activity) after it goes to background, or the user press the home button. From v2.0, we keep the inline activity window with the caller app window(bug 1028502), that means for the inline activities, if we want to keep the behaviour - closed immediately after it goes to background, then the apps needed to handle this case by themselves, that's, the ringtone app needs to listen to visibility changes and close itself if it's in background.

I will attach a patch later and probably needinfo from ux people to confirm my suggestion fix.

Comment 12

[Dominic Kuo [:dkuo]]

Attachment: patch

Jim, I have commented the root cause in comment 11 and hope my fix make sense, would you please review this? thanks.

Comment 13

[Dominic Kuo [:dkuo]]

Katie, would you please read comment 11 and see if I am doing right for this ringtones issue? thanks!

Comment 14

[Jim Porter (:squib)]

Comment on attachment 8512450 [details] [review]
patch

It seems like this is actually an AudioChannel bug, and not something we need to change in the ringtones app. The ringtones app makes a special effort to block background audio from playing while we're previewing a ringtone. It's possible we're doing something wrong there, but otherwise, I think the fix for this should be in the AudioChannel code.

That said, if an AudioChannel fix for this is too complex for 2.1, I wouldn't mind adding this as a temporary workaround.

Also, see my comments on GitHub if we ultimately do decide to use this patch.

Comment 15

[Dominic Kuo [:dkuo]]

(In reply to Jim Porter (:squib) from comment #14)
> Comment on attachment 8512450 [details] [review]
> patch
> 
> It seems like this is actually an AudioChannel bug, and not something we
> need to change in the ringtones app. The ringtones app makes a special
> effort to block background audio from playing while we're previewing a
> ringtone. It's possible we're doing something wrong there, but otherwise, I
> think the fix for this should be in the AudioChannel code.
> 
> That said, if an AudioChannel fix for this is too complex for 2.1, I
> wouldn't mind adding this as a temporary workaround.
> 
> Also, see my comments on GitHub if we ultimately do decide to use this patch.

Thanks Jim, it make sense to fix this issue in AudioChannel if ringtones app already have the logic for audio competing, so I will just leave my patch for 2.1 if needed.

Randy, would you please see if AudioChannel could do something for this issue? thanks.

Comment 16

[Jim Porter (:squib)]

I can't reproduce this on master, probably because it has bug 1043762, which hasn't been uplifted yet.

Comment 17

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

I think it's not easy to have a quick fix on audiochannelServices for this kind of visibility problem.
In the audioChannelServices, we already has a lot of hack for those competing rule.
And it's easy to introduce another side effect even solve this problem.
In 2.2, Dominic and I already have plan to do the refactor for audiochannelServices.(Bug 1089539).

Comment 18

[Jim Porter (:squib)]

(In reply to Randy Lin [:rlin] from comment #17)
> I think it's not easy to have a quick fix on audiochannelServices for this
> kind of visibility problem.

I think we can actually fix this by uplifting bug 1043762 (plus bug 1091137, which fixes an issue in that patch). It seems like this is an issue with how AudioContexts are created, but bug 1043762 changes how we do that, so it fixes the problem for me at least...

Comment 19

[Ken Chang[:kenkai]]

vasanth, can you please check if the patch of bug 1043762 fixes this bug?

Comment 20

[vasanth]

Issue fixed with patches from bug 1043762 and bug 1091137!
At any time, only ringtone or music is heard.

In ringtone page, last music is heard till we select ringtone again. 
I guess this is fine.

Comment 21

[StevenLee[:slee]]

Hi Bobby,

As comment 20, can you please uplift the patches in bug 1043762 and bug 1091137.
Thanks.

Comment 22

[Bobby Chien]

Bhavana, please help uplift patch. many thanks.

Comment 23

[Bobby Chien]

bug 1043762, bug 1091137 approved.

Comment 24

[Ken Chang[:kenkai]]

According to comment 20, close this bug as duplicate of 1043762. And Randy will do followup task in bug 1089539.