Closed
Bug 1091137
Opened 10 years ago
Closed 10 years ago
[ringtones] JavaScriptError: (17) TypeError: this._source is undefined
Categories
(Firefox OS Graveyard :: Gaia::Ringtones, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: squib, Assigned: squib)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
djf
:
review+
bajaj
:
approval-gaia-v2.0+
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
This broke from bug 1043762. I also fixed a regression from bug 1048673 because I happened to notice it while mucking about in here. Not much else to say here. Have an error log:
https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/JgYe6YLmTA2mFQL0nDv-xg/5/public/logs/live_backing.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1414606736&Signature=bQHsTYkRGTZR0uizGxZ5yxDU1Rw%3D
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #8513700 -
Flags: review?(dflanagan)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8513700 [details] [review]
Fix it
looks good to me
Attachment #8513700 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Flags: in-testsuite+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8513700 [details] [review]
Fix it
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1043762, bug 1048673
[User impact] if declined: Previewing ringtones can break if you hide the ringtones app and return to it; also, without this patch, the tree is red
[Testing completed]: Backed by existing marionette tests
[Risk to taking this patch] (and alternatives if risky): Low-risk
[String changes made]: None
Attachment #8513700 -
Flags: approval-gaia-v2.1?
Attachment #8513700 -
Flags: approval-gaia-v2.0?
|
||
Comment 5•10 years ago
|
||
(In reply to Jim Porter (:squib) from comment #4)
> Comment on attachment 8513700 [details] [review]
> Fix it
>
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #): bug 1043762, bug 1048673
> [User impact] if declined: Previewing ringtones can break if you hide the
> ringtones app and return to it; also, without this patch, the tree is red
> [Testing completed]: Backed by existing marionette tests
> [Risk to taking this patch] (and alternatives if risky): Low-risk
> [String changes made]: None
Bhavana, we need your help to uplift this. it will also fix bug 1087200.
Flags: needinfo?(bbajaj)
|
||
Updated•10 years ago
|
Attachment #8513700 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
|
||
Updated•10 years ago
|
Attachment #8513700 -
Flags: approval-gaia-v2.0? → approval-gaia-v2.0+
|
||
Comment 7•10 years ago
|
||
|
|
||
Comment 8•10 years ago
|
||
Needs rebasing for v2.0 uplift.
status-b2g-v2.0:
--- → affected
Flags: needinfo?(squibblyflabbetydoo)
|
|
Assignee | |
Comment 9•10 years ago
|
||
If possible, please grant 2.0 approval for bug 1048673. Then we won't need rebasing (and 2.0 will be slightly less broken).
Flags: needinfo?(squibblyflabbetydoo)
|
|
||
Comment 10•10 years ago
|
||
|
|
||
Updated•10 years ago
|
status-b2g-v2.0M:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•