Entering manually a bug number in the pinboard doesn't work anymore

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mdoglio, Assigned: mdoglio)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This is the out put I see in the devtools console:
"Error: inputValue.replace is not a function
.link/<@http://local.treeherder.mozilla.org/ui/js/directives/main.js:134:35
NgModelController</this.$$parseAndValidate@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:20411:22
NgModelController</this.$commitViewValue@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:20401:5
NgModelController</this.$$debounceViewValueCommit/<@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:20529:9
$RootScopeProvider/this.$get</Scope.prototype.$eval@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:14123:16
$RootScopeProvider/this.$get</Scope.prototype.$apply@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:14221:18
NgModelController</this.$$debounceViewValueCommit@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:20528:7
NgModelController</this.$setViewValue@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:20500:7
baseInputType/listener@http://local.treeherder.mozilla.org/ui/vendor/angular/angular.js:19300:7
jQuery.event.dispatch@http://local.treeherder.mozilla.org/ui/vendor/jquery-2.0.3.js:4675:15
jQuery.event.add/elemData.handle@http://local.treeherder.mozilla.org/ui/vendor/jquery-2.0.3.js:4360:6
"
(Assignee)

Comment 1

3 years ago
Created attachment 8509565 [details] [review]
PR 244 on treeherder-ui

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/55233e8d8c803087e7538bd553f71d99f5c68185
Bug 1087407 - Entering manually a bug number in the pinboard doesn't work anymore

https://github.com/mozilla/treeherder-ui/commit/64b9b9c1e2536f1f4d324f75ade924032aed3ed1
Merge pull request #244 from mozilla/bug-1087407-fix

Bug 1087407 - Entering manually a bug number in the pinboard doesn't wor...
Indeed. That's bizarre, I just verified it working on dev/stage 6 days ago while verifying bug 1073050.

Comment 4

3 years ago
(In reply to Jonathan French (:jfrench) from comment #3)
> Indeed. That's bizarre, I just verified it working on dev/stage 6 days ago
> while verifying bug 1073050.

grunt build hadn't been re-run, so stage would have not been using angular 1.3

Updated

3 years ago
Assignee: nobody → mdoglio
Blocks: 1084608
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 5

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bb396b991c3ba23063786d7edf79c0a5790ce28a
Bug 1087407 - Entering manually a bug number in the pinboard doesn't work anymore

https://github.com/mozilla/treeherder/commit/c303f4bb7bbb94adc0042d5e2b8192b55826da24
Merge pull request #244 from mozilla/bug-1087407-fix

Bug 1087407 - Entering manually a bug number in the pinboard doesn't wor...
You need to log in before you can comment on or make changes to this bug.