1087464 - [Ringtones] Songs are not added to ringtones list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Description

[Jim Porter (:squib)]

Cloning because this is still happening for me on the latest Gecko/Gaia on a Flame (v188 firmware). Seems to happen with every file, regardless of format or whether it has album art.

+++ This bug was initially created as a clone of Bug #1076975 +++

Description:
When a user tries to add a song as a ringtone it will never appear in the list of ringtones as an option. This occurs wether the user adds the song through settings or the music app.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141001170320
2) Go to Setting > Sounds > Manage Tones
3) Click the "+" icon in the top right
4) Select a song and add it as a ringtone.
5) Observe list of ringtones options
  
Actual:
The song is never added as a ringtone option.
  
Expected: 
It is expected that the song is added as a ringtone option
  
Environmental Variables:
Device: Flame 2.2 Master (Shallow Flash)
BuildID: 20141001170320
Gaia: 191d805f4911628d37a8a90a1e23a6013995138f
Gecko: 2399d1ae89e9
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Repro frequency: 100%
See attached: video clip(http://youtu.be/4LO-1PQvCBM), logcat

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I cannot reproduce this.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Ugh, the reason I couldn't reproduce was because apparently we don't run Nuwa on DEBUG builds.

<!!! !!! !!!/>

I was using the wrong ContentParent when Nuwa was cloning PBackground. Sheesh.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This goes back all the way to bug 956218.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/b2g-inbound/rev/8f7a258843e4

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8510722 [details] [diff] [review]
Patch, v1

Approval Request Comment
[Feature/regressing bug #]: Bug 956218
[User impact if declined]: Optimized builds randomly crash.
[Describe test coverage new/current, TBPL]: Apparently QA sees this in smoketests, and others are working on adding automated coverage.
[Risks and why]: Low risk, this is obviously correct.
[String/UUID change made/needed]: None

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

[Tracking Requested - why for this release]:

(In reply to ben turner [:bent] (use the needinfo? flag!) from comment #3)
> This goes back all the way to bug 956218.

Though since IndexedDB is the only in-tree consumer, and it was just added on aurora, I don't think this needs to be pushed back any further.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Nuwa will hopefully run on DEBUG builds when bug 1050122 is fixed.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f7a258843e4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c11621d7a35c