Closed Bug 1087650 Opened 5 years ago Closed 5 years ago

"Exclusion profiles" are still being called "Visibility profiles" in a few places

Categories

(Tree Management :: Treeherder, defect, P4)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: KWierso, Unassigned)

Details

Sign in with an account that shows the Sheriffing menu.
Text above the Exclusion profile list reads "Exclusion profiles" and then a link to "Job exclusions".
Click the link to "Job exclusions".
The text that was "Exclusion profiles" has now changed to a link to "Visibility profiles".


It should either stay as "Exclusion profiles" in both cases or else change to "Visibility profiles" in both cases.
The name was changed in:
https://github.com/mozilla/treeherder-ui/commit/5cb8af27b1eb83f4ca8772faed78f82779ce3d0a#diff-2d715bdbfc24cdba82af7b19b1e19e26L4

Agree it should be made consistent.

I think we should go with "Exclusion profiles", since they are excluding jobs, not making them visible.
Priority: -- → P3
Summary: "Sheriffing" menu text changes confusingly. → "Exclusion profiles" are still being called "Visibility profiles" in a few places
Bug 1087560 landed with this bug number in case anybody comes here looking for it.
No longer blocks: treeherder-dev-transition
Priority: P3 → P4
This seems to be fixed as a by-product of other work, and Wes agrees, so marking fixed.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
And verified on production.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.