Added bug comments when adjusting reviewers doesn't make a lot of sense

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: gps, Unassigned)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1946] )

(Reporter)

Description

4 years ago
As part of writing tests to cover the review flag integration, I've noticed the Review Board likes to add comments every time it adjusts review flags. This can result in a redundant mass of similar comments. Take this test excerpt for example:

---

Removing all reviewers should remove all flags

  $ rbmanage remove-reviewer $HGPORT1 3 --user reviewer
  0 people listed on review request

  $ rbmanage publish $HGPORT1 3

  $ bugzilla dump-bug 2
  Bug 2:
    attachments:
    - attacher: author@example.com
      content_type: text/x-review-board-request
      data: http://example.com/r/3/
      description: 'MozReview Request: bz://2/mynick'
      flags: []
      id: 2
      summary: 'MozReview Request: bz://2/mynick'
    comments:
    - author: author@example.com
      id: 6
      tags: []
      text: ''
    - author: author@example.com
      id: 7
      tags: []
      text: 'Created attachment 2 [details] [diff] [review]
  
        MozReview Request: bz://2/mynick'
    - author: author@example.com
      id: 8
      tags: []
      text: '/r/4 - Bug 2 - Multiple reviewers
  
  
        Pull down this commit:
  
  
        hg pull review -r d17099d7ee43e288f43e0210edc71b9782f92b77'
    - author: author@example.com
      id: 9
      tags: []
      text: '/r/4 - Bug 2 - Multiple reviewers
  
  
        Pull down this commit:
  
  
        hg pull review -r d17099d7ee43e288f43e0210edc71b9782f92b77'
    - author: author@example.com
      id: 10
      tags: []
      text: '/r/4 - Bug 2 - Multiple reviewers
  
  
        Pull down this commit:
  
  
        hg pull review -r d17099d7ee43e288f43e0210edc71b9782f92b77'
    summary: Multiple Reviewers

---

We should make the comment more intelligent - possibly by removing the text completely from flag-only adjustments.
(Reporter)

Updated

4 years ago
Priority: -- → P2

Updated

4 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1946]

Updated

4 years ago
Duplicate of this bug: 1098110

Updated

4 years ago
Depends on: 1055021

Comment 2

4 years ago
We have too many P1s, so I'm spreading out the priorities.  P3 -> P4, P2 -> P3, and some portion of P1s will become P2.
Priority: P2 → P3

Comment 3

3 years ago
I believe this was fixed as part of Bug 1229789.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.