108782 - execute() can't handle args with i18n chars that aren't Latin-1

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Curt Patrick (gone)]

(From Dan Veditz)
In /cvsroot/mozilla/xpinstall/src/nsInstallExecute.cpp,v:
>+      cArgs[argc++] = ToNewCString(mArgs);

mArgs is unicode, isn't it? I realize the code already converted this way
before, but we should at least file a bug that execute() can't handle
args with i18n chars that aren't Latin-1. 
(several other places need to be fixed to make it really work anyway).

Comment 1

[Henrik Gemal]

not installer...

Comment 2

[Daniel Veditz [:dveditz]]

setting back to curt

Comment 3

[Jimmy Lee]

Ccing Grace. :-)