1087942 - Port BoxObject and its subclasses to WebIDL (Port Bug 979835 to SeaMonkey)

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Comment 1

[Philip Chee]

Attachment: Patch v1 proposed fix.

> for the toolbar.xml one you just remove the QI
Fixed.
> for the threadPane.js one you could use the treeBoxObject property on the tree to avoid doing the QI yourself
Fixed.
> I think the other two should just work anyway, since they left stubs in

https://hg.mozilla.org/mozilla-central/rev/8d3304b7e0e0

For FeedWriter.js I followed what they did in Bug 979835
http://hg.mozilla.org/mozilla-central/rev/8d3304b7e0e0#l15.11
>            var popupbox = this._handlersMenuList.firstChild.boxObject;
> -          popupbox.QueryInterface(Components.interfaces.nsIPopupBoxObject);


For mailWidgets.xml I followed what they did in Bug 979835.

> -            this.boxObject.QueryInterface(Components.interfaces.nsIMenuBoxObject).openMenu(false);
> +            this.boxObject.openMenu(false);

Comment 2

[[e-mail]]

Attachment: More tree box objects

treeBoxObject.view is no longer an nsITreeView (tree.xml has to work around this bug) and there are a few other places (pun intended) where we depended on this. This gets the history window working for me, but obviously bookmarks has its own problems.

Comment 3

[Philip Chee]

Comment on attachment 8510526 [details] [diff] [review]
More tree box objects

Opening the History window do something then close the window:

Fri Oct 24 2014 23:54:39
Error: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative
Source file: chrome://communicator/content/history/treeView.js
Line: 1019

Comment 4

[[e-mail]]

(In reply to Philip Chee from comment #3)
> Opening the History window do something then close the window:
> 
> Fri Oct 24 2014 23:54:39
> Error: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a
> WrappedNative
> Source file: chrome://communicator/content/history/treeView.js
> Line: 1019

Unrelated. Kairo missed the change as part of bug 543444. places/treeView.js is correct.

Comment 5

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/9be20e940504
http://hg.mozilla.org/comm-central/rev/5f2cc63708bc