Closed Bug 1088060 Opened 8 years ago Closed 8 years ago

[mozversion] Get all application and platform data

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 2 obsolete files)

get all information v1.2
3.62 KB, patch
whimboo
: review+
Details | Diff | Splinter Review 
In case of Mozmill we would like to know about the application id when using mozversion. So it would be great if we not only read specific values but all of them. Patch is simple and I will upload it in a bit.
Attached patch get all information v1 (obsolete) — — Splinter Review
Attachment #8510349 - Flags: review?(dave.hunt)
Attached patch get all information v1.1 (obsolete) — — Splinter Review 
Actually we should not leave platform_milestone but rename it to platform_version to be in sync with application.
Attachment #8510349 - Attachment is obsolete: true
Attachment #8510349 - Flags: review?(dave.hunt)
Attachment #8510358 - Flags: review?(dave.hunt)
Comment on attachment 8510358 [details] [diff] [review]
get all information v1.1

Review of attachment 8510358 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. My only question would be over milestone/version for platform. If there's a good reason for these to be distinct in the INI files then perhaps we should consider retaining the distinction?
Attachment #8510358 - Flags: review?(dave.hunt) → review+
(In reply to Dave Hunt (:davehunt) from comment #3)
> Looks good. My only question would be over milestone/version for platform.
> If there's a good reason for these to be distinct in the INI files then
> perhaps we should consider retaining the distinction?

I looked around and have seen that the Services module offers appInfo.platformVersion. So as agreed on IRC we will go with the rename of milestone to version. Thanks for the quick review Dave!
The last patch was a git one, so I converted it to hg.
Attachment #8510358 - Attachment is obsolete: true
Attachment #8510377 - Flags: review+
Inbound is currently closed. So someone should land it later.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/370a0a1ea55d
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/370a0a1ea55d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.