Closed
Bug 1088060
Opened 7 years ago
Closed 7 years ago
[mozversion] Get all application and platform data
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file, 2 obsolete files)
3.62 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
In case of Mozmill we would like to know about the application id when using mozversion. So it would be great if we not only read specific values but all of them. Patch is simple and I will upload it in a bit.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8510349 -
Flags: review?(dave.hunt)
Assignee | ||
Comment 2•7 years ago
|
||
Actually we should not leave platform_milestone but rename it to platform_version to be in sync with application.
Attachment #8510349 -
Attachment is obsolete: true
Attachment #8510349 -
Flags: review?(dave.hunt)
Attachment #8510358 -
Flags: review?(dave.hunt)
Comment 3•7 years ago
|
||
Comment on attachment 8510358 [details] [diff] [review] get all information v1.1 Review of attachment 8510358 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. My only question would be over milestone/version for platform. If there's a good reason for these to be distinct in the INI files then perhaps we should consider retaining the distinction?
Attachment #8510358 -
Flags: review?(dave.hunt) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Dave Hunt (:davehunt) from comment #3) > Looks good. My only question would be over milestone/version for platform. > If there's a good reason for these to be distinct in the INI files then > perhaps we should consider retaining the distinction? I looked around and have seen that the Services module offers appInfo.platformVersion. So as agreed on IRC we will go with the rename of milestone to version. Thanks for the quick review Dave!
Assignee | ||
Comment 5•7 years ago
|
||
The last patch was a git one, so I converted it to hg.
Attachment #8510358 -
Attachment is obsolete: true
Attachment #8510377 -
Flags: review+
Assignee | ||
Comment 6•7 years ago
|
||
Inbound is currently closed. So someone should land it later.
Keywords: checkin-needed
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/370a0a1ea55d
Comment 8•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/370a0a1ea55d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•