[e10s] after dragging tab to new window, links with target blank open in tabs in old window instead of current window

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: martin, Assigned: mconley)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 40
x86
Windows 7
Points:
8
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(e10sm6+, firefox40 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Story
enable e10s
Open Multiple Tabs
drag some to a new window
All links with the target attribute set to _blank will open in the old window

Expected result:
Tabs opened by clicking links with target = _blank should open in the current window

Reproducible: Always on build ID Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141022030202 CSet: 88adcf8fef83

Possibly related bugs: bug 1047603
(Reporter)

Updated

3 years ago
tracking-e10s: --- → ?
Depends on: 1012784
(Reporter)

Comment 1

3 years ago
Sample Page with links that have target = _blank :
http://www.heise.de/security/meldung/lost-found-Was-von-der-Woche-uebrig-blieb-2411458.html (sorry german)
tracking-e10s: ? → m6+

Updated

3 years ago
Blocks: 516752
Component: General → Tabbed Browser
(Reporter)

Comment 2

3 years ago
Reproducible on build:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141122030204 CSet: 7ab92d922d19
Flags: firefox-backlog+

Comment 3

3 years ago
dupe of bug 1124881?

Updated

3 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 1134375
Assignee: nobody → mconley
Points: --- → 8
Flags: qe-verify-
Status: NEW → ASSIGNED
(In reply to Jim Mathies [:jimm] from comment #3)
> dupe of bug 1124881?

Possibly. Investigating now, and I'll see what I find out.
See Also: → bug 1124881
Unable to reproduce bug 1124881, so I've needinfo'd blassey.

I can still reproduce this one though, and the problem here is that we're not swapping the mBrowserDOMWindow's on the TabParent's when we swap remote frame loaders. Patch coming up.
Created attachment 8590502 [details] [diff] [review]
bug-1088180.patch

I assume because I have no direct access to the nsIBrowserDOMWindow pointers under TabParent that there's no other way of doing this?
Attachment #8590502 - Flags: review?(bugs)
Attachment #8590502 - Flags: review?(bugs) → review+
Thanks for the fast review!

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/14f69f2f4712
https://hg.mozilla.org/mozilla-central/rev/14f69f2f4712
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40

Updated

3 years ago
Iteration: --- → 40.1 - 13 Apr
Created attachment 8598682 [details]
Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1088180.html
You need to log in before you can comment on or make changes to this bug.