1088204 - Display a notification banner in the treeherder UI when a production push occurs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P5)

Description

[Jonathan French (:jfrench)]

Just an idea discussed today, it might be handy if during a push to production, we:

- push an IRC gitbot-like message to the #treeherder channel
- potentially also provide in-app messaging that a push is underway

For the 2nd part, if we did that, perhaps a Treeherder balloon dialogue overlaying the top navbar, and message perhaps similar to:

"The production instance is being re-deployed, please grab a coffee for [n]minutes, then reload this page." - with an accompanying dismiss button.

This would prevent Sheriffs and other users from thinking Treeherder has gone down, and differentiating between that and a prod push.

Comment 1

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #0)
> - push an IRC gitbot-like message to the #treeherder channel

This is bug 1076885 :-)

Let's make the bug about this second part (which will likely be lower priority once bug 1076885 is fixed and/or we sort out the rough edges in our deployment script):

> - potentially also provide in-app messaging that a push is underway

Comment 2

[Jonathan French (:jfrench)]

Gah, thanks Ed. :) Perhaps Bugzilla didn't warn me of a possible dupe since 1076885 was a different product.

Comment 3

[Ed Morley [:emorley]]

Yeah unfortunately the configs for Chief are centralised and not under our control, so I filed over there.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:bug1088204 > mozilla:master

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

This appears to work for me when testing locally with vagrant (plus manually creating the revision.txt file since I don't think it gets created normally in a vagrant run). 
It does add a dependency on gitpython, which we might not want to have running on the server, so I'm open to better ideas on how to get the server's revision. :)

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

UI-only solutoj now, so punting to Will :-)

Comment 7

[Ed Morley [:emorley]]

Solution, even

Comment 8

[William Lachance (:wlach)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

This lgtm, I have a few comments and a suggestion on how to implement the notification as an infobox.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

Re-flagging review because the patch has made a bunch of changes since the r+.

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

Seems like a good approach, but there's a few changes I'd like to see before this goes in.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

Addressed all but one of the comments, and the fifth doesn't seem super important to me.

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

Just a few more things to be addressed. Sorry for the delay reviewing this, will be faster next time. :)

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

How about this?

Comment 14

[William Lachance (:wlach)]

Comment on attachment 8798540 [details] [review]
[treeherder] KWierso:bug1088204 > mozilla:master

This is very close, but I think it would be better if you created a partial especially for the update and included it from index.html, so it was always visible no matter what the user's scroll position. r+ with the addressed.

Comment 15

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b6f411d8cd9fc0279f9248f6a788b77b7081d1e5
Bug 1088204 - Warn the user when server revision has changed (#1901) r=wlach