1321920 - Console error on page load: MainCtrl Error loading revision.txt

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

I've noticed this single line console error on page load running latest master locally with web_server.js.

MainCtrl Error loading revision.txt: Not Found

Related to bug 1088204 ?
https://github.com/mozilla/treeherder/blob/master/ui/js/controllers/main.js#L34

Maybe you guys expect this, if so apologies and feel free to turf this bug.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1321920 > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8816654 [details] [review]
[treeherder] KWierso:1321920 > mozilla:master

Low priority review request, nothing's actually broken, but the revision checker IS being a bit spammy (only on first attempting a page load, though) when running locally where there is no revision.txt file.

This switches the log() to a debug(), which makes me not see it anymore when testing locally right now.

I think we could also just do nothing in the failure case, if you'd prefer that.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8816654 [details] [review]
[treeherder] KWierso:1321920 > mozilla:master

This seems like a good enough solution, we can always revisit later if need be.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/18fc90c9409dfe886015e5eb12a481e5c15f8e82
Bug 1321920 - Switch the revision checker failure case from log() to debug() (#2019) r=wlach