1088275 - nsSSLStatus is not threadsafe, despite claiming it is

Status: RESOLVED DUPLICATE of bug 698243

(Core :: Security: PSM, defect, P2)

Description

[Dana Keeler (she/her) [:keeler]]

nsSSLStatus.h has the following:

17 class nsSSLStatus MOZ_FINAL
18   : public nsISSLStatus
19   , public nsISerializable
20   , public nsIClassInfo
21 {
22 protected:
23   virtual ~nsSSLStatus();
24 public:
25   NS_DECL_THREADSAFE_ISUPPORTS

(note in particular line 25)
However, nsSSLStatus has no mechanisms that prevent data races.
I may be misinterpreting what NS_DECL_THREADSAFE_ISUPPORTS means, but from what I can see, nsSSLStatus objects can be accessed (and are accessed) on multiple threads. We should add a lock and maybe not make all of its members public so that we can't accidentally do the unsafe thing.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

See bug 698243 and the other bugs about this. I think there are at least three different bugs about this topic.