698243 - nsNSSSocketInfo and nsSSLStatus are succeptable to race conditions

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

In bug 686248, I attempt to avoid some rances caused by changes to mSSLStatus (in nsNSSSocketInfo) or to mServerCert (in nsSSLStatus) by copying the references into nsRefPtrs before using them, in case they are changed by another thread. However, nsSSLStatus needs locks to ensure that mServerCert is kept in sync with other attributes. nsNSSSocketInfo probably needs locks to ensure that the Read(), Write(), and main-thread-callable methods (mostly getters for nsITransportSecurityInfo attributes) don't race with operations on the SSL thread / socket transport thread.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Don't forget that some nsNSSSocketInfo/nsSSLStatus methods that need modification are in nsIdentityChecking.cpp (and should be moved to where they belong).

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information