Closed Bug 1088364 Opened 10 years ago Closed 10 years ago

Remove use cases of mozL10n.localize from Bluetooth

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

      No description provided.
Blocks: 1020137
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attached file pull request
Hard to grep case of mozL10n.localize use. I believe it's the last one.
Attachment #8510678 - Flags: review?(stas)
Attachment #8510678 - Flags: review?(stas) → review?(echou)
Comment on attachment 8510678 [details] [review]
pull request

Delegate review request to Ian since he is the owner of Gaia bluetooth app and this is a Gaia change.
Attachment #8510678 - Flags: review?(echou) → review?(iliu)
Comment on attachment 8510678 [details] [review]
pull request

Hi Zibi, I leave some comment on GitHub. Basically, we have to sync the code base with https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/bluetooth.js . It's a duplicated one for implementation embedded Bluetooth app in the future. Thanks.
Attachment #8510678 - Flags: review?(iliu)
Comment on attachment 8510678 [details] [review]
pull request

Updated PR
Attachment #8510678 - Flags: review?(iliu)
Comment on attachment 8510678 [details] [review]
pull request

Thanks for Zibi's help here. Working and r+ with me.
Attachment #8510678 - Flags: review?(iliu) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: