Closed Bug 1020137 Opened 9 years ago Closed 9 years ago

Clean up use cases of mozL10n.localize

Categories

(Firefox OS Graveyard :: Gaia::L10n, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::L10n
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: zbraniecki, Unassigned, Mentored)

References

Details

(Whiteboard: [good first bug])

User Story

Migrate all mozL10n.localize use cases to:

if no l10nArgs: node.setAttribute('data-l10n-id', l10nId);

if l10nArgs: navigator.mozL10n.setAttributes(node, l10nId, l10nArgs);
Once bug 992473 and bug 994519 are fixed, we should clean up uses of mozL10n.localize

There are 84 uses in gaia apps, and I suspect that most of them should stay, but they may have redundant code (that applies content to node etc.).
Depends on: 994519, 992473
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
we want to split this work into two chunks:

 - add the updated API in bug 994519
 - convert the uses of localize and remove it in this bug.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Marking as good first bug.

All we have to do here is find all uses of mozL10n.localize and replace them with mozL10n.setAttributes.
Mentor: gandalf
Whiteboard: [good first bug]
Blocks: 999779
Priority: -- → P3
Depends on: 1037637
Depends on: 1041403
Depends on: 1043615
User Story: (updated)
Depends on: 1047347
Depends on: 1052136
I would like to work on this bug! can you assign this to me!
Depends on: 1057798
Depends on: 1058985
Depends on: 1073893
We're done with mozL10n.localize! Thanks everyone who has helped with patches and reviews :)
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Depends on: 1088364
You need to log in before you can comment on or make changes to this bug.