1088465 - Cleanup how mocks are set in MozLoopService

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Matthew N. [:MattN]]

Attachment: v.1 Use a |mocks| property

Having the arguments everywhere for mock push handlers and websockets make it hard to implement the action button to retry an action in bug 1074670 since I'd have to pass those arguments along when we retry. It seems quite busy regardless to pass the arguments a ~4 calls deep.

Comment 1

[Mike de Boer [:mikedeboer]]

Comment on attachment 8510767 [details] [diff] [review]
v.1 Use a |mocks| property

Review of attachment 8510767 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this! Looks mighty good. I'll see if I can land this today, after a try run.

::: browser/components/loop/LoopCalls.jsm
@@ +312,5 @@
>      let callProgress = new CallProgressSocket(
>        callData.progressURL,
>        callData.callId,
>        callData.websocketToken);
> +    callProgress._websocket = this.mocks.webSocket;

As you're here, could you add a conditional to this line? At first it scared me quite a bit. But it appears to not have any side effects before `connect()` is called.
A comment would suffice too.

Comment 2

[Mike de Boer [:mikedeboer]]

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=48e4949baec9

Comment 3

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/0eb3fe5855a0

Matt, is this all the work you meant to do in this bug?

Comment 4

[Matthew N. [:MattN]]

Yes, and thanks for landing.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0eb3fe5855a0

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f0874bd9c8d

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8510767 [details] [diff] [review]
v.1 Use a |mocks| property

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only