Closed Bug 1074670 Opened 10 years ago Closed 10 years ago

Implement NotificationView's button (e.g. retry)

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
5

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla36
Iteration:
36.3
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: MattN, Assigned: MattN)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry)
38 bytes, text/x-review-board-request
pkerr
: review+
Details
The error bar has a details bar below it which can have an optional button aka. detailsButton e.g. to "Retry" an action upon error. This bug should finish the button so it can actually retry some action upon click and style it appropriately.
Flags: qe-verify+
Flags: firefox-backlog+
backlog: --- → Fx35?
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Whiteboard: [rooms]
Depends on: 1088465
This is not a rooms, but we want it for Fx35 -- which is why the blocking-loop Fx35+ flag is set.
backlog: Fx35? → Fx35+
Whiteboard: [rooms]
Depends on: 1089919
Iteration: 36.1 → ---
Depends on: 1091161
Iteration: --- → 36.2
Depends on: 1093500
Iteration: 36.2 → 36.3
Attached file MozReview Request: bz://1074670/MattN (obsolete) —
Attachment #8520698 - Flags: review?(pkerr)
Attachment #8520698 - Flags: review?(jaws)
/r/407 - Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry) Pull down this commit: hg pull review -r ee559453fffe28fd9d6d4790abd9186bc96b45e4
/r/407 - Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry) Pull down this commit: hg pull review -r 30cfc8f225d95fa09cfe4a61edd25a4a6c4e06ae
https://reviewboard.mozilla.org/r/405/#review203 ::: browser/components/loop/content/shared/js/views.js (Diff revision 2) > ), Whitespace nit.
Comment on attachment 8520698 [details] MozReview Request: bz://1074670/MattN Comments found at https://reviewboard.mozilla.org/r/405/.
Attachment #8520698 - Flags: review?(pkerr) → review+
https://reviewboard.mozilla.org/r/405/#review205 > Whitespace nit. That's from build-jsx. The jsx file doesn't have the trailing whitespace.
Thanks Paul! Results will be displayed on Treeherder as they come in: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6337637fccc1 Alternatively, view them on TBPL (soon to be deprecated): https://tbpl.mozilla.org/?tree=Try&rev=6337637fccc1
Keywords: checkin-needed
Attachment #8520698 - Flags: review?(jaws)
https://hg.mozilla.org/integration/fx-team/rev/3e5a8432885b
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3e5a8432885b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
Hi Pauly -- can you verify this with last night's Nightly?
Flags: needinfo?(paul.silaghi)
status-firefox35: --- → affected
status-firefox36: --- → fixed
Depends on: 1098629
QE verification is too hard without being able to manipulate HTTP requests so verification can wait until bug 1098629.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(paul.silaghi)
Attachment #8520698 - Attachment is obsolete: true
Attachment #8618381 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: