1074670 - Implement NotificationView's button (e.g. retry)

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Matthew N. [:MattN]]

The error bar has a details bar below it which can have an optional button aka. detailsButton e.g. to "Retry" an action upon error.

This bug should finish the button so it can actually retry some action upon click and style it appropriately.

Comment 1

[Maire Reavy [:mreavy]]

This is not a rooms, but we want it for Fx35 -- which is why the blocking-loop Fx35+ flag is set.

Comment 2

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1074670/MattN

Comment 3

[Matthew N. [:MattN]]

/r/407 - Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry)

Pull down this commit:

hg pull review -r ee559453fffe28fd9d6d4790abd9186bc96b45e4

Comment 4

[Matthew N. [:MattN]]

/r/407 - Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry)

Pull down this commit:

hg pull review -r 30cfc8f225d95fa09cfe4a61edd25a4a6c4e06ae

Comment 5

[Paul Kerr [:pkerr]]

https://reviewboard.mozilla.org/r/405/#review203

::: browser/components/loop/content/shared/js/views.js
(Diff revision 2)
>              ), 

Whitespace nit.

Comment 6

[Paul Kerr [:pkerr]]

Comment on attachment 8520698 [details]
MozReview Request: bz://1074670/MattN

Comments found at https://reviewboard.mozilla.org/r/405/.

Comment 7

[Matthew N. [:MattN]]

https://reviewboard.mozilla.org/r/405/#review205

> Whitespace nit.

That's from build-jsx. The jsx file doesn't have the trailing whitespace.

Comment 8

[Matthew N. [:MattN]]

Thanks Paul!

Results will be displayed on Treeherder as they come in:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6337637fccc1

Alternatively, view them on TBPL (soon to be deprecated):
https://tbpl.mozilla.org/?tree=Try&rev=6337637fccc1

Comment 9

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/3e5a8432885b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e5a8432885b

Comment 11

[Maire Reavy [:mreavy]]

Hi Pauly -- can you verify this with last night's Nightly?

Comment 12

[Matthew N. [:MattN]]

QE verification is too hard without being able to manipulate HTTP requests so verification can wait until bug 1098629.

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/667abd3fc58d

Comment 15

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1074670 - Implement the Hello NotificationView's button (e.g. retry)