[Text Selection] Hard to selectword and cannot drag selection caret inside a iframe.

RESOLVED FIXED in mozilla36

Status

()

Core
Selection
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mtseng, Assigned: mtseng)

Tracking

unspecified
mozilla36
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
For example, if we open uitest app and switch to copy/paste test. Then scroll content to the bottom. Select word is hard to trigger or there is an offset between your finger and actually select word's position. Also hard to drag those carets in this state.
(Assignee)

Comment 1

3 years ago
Created attachment 8510906 [details] [diff] [review]
wrong-coord-system

I found that we change GetFrameForPoint from canvas frame to root frame in Bug 1068461. But most of our points are in canvas frame's coordinate. So we are using wrong coordinate system now. So I change our most points to root frame's coordinate.
Attachment #8510906 - Flags: review?(roc)
(Assignee)

Comment 2

3 years ago
Created attachment 8510908 [details] [diff] [review]
wrong-coord-system v2

Update corresponding comment in header.
Attachment #8510906 - Attachment is obsolete: true
Attachment #8510906 - Flags: review?(roc)
Attachment #8510908 - Flags: review?(roc)
I've verified that SelectWord works after apply this patch. However the patch does apply cleanly on master.
Attachment #8510908 - Flags: review?(roc) → review+

Updated

3 years ago
Blocks: 1087193
(Assignee)

Comment 4

3 years ago
Created attachment 8512460 [details] [diff] [review]
wrong-coord-system v3 (carry r+: roc)

Rebased.

try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3596a027afa0
Attachment #8510908 - Attachment is obsolete: true
(Assignee)

Comment 5

3 years ago
Created attachment 8513132 [details] [diff] [review]
wrong-coord-system v4 (carry r+: roc)

Rebased.
Attachment #8512460 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9bbad391201
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a9bbad391201
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.