1088552 - [Text Selection] Hard to selectword and cannot drag selection caret inside a iframe.

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

For example, if we open uitest app and switch to copy/paste test. Then scroll content to the bottom. Select word is hard to trigger or there is an offset between your finger and actually select word's position. Also hard to drag those carets in this state.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wrong-coord-system

I found that we change GetFrameForPoint from canvas frame to root frame in Bug 1068461. But most of our points are in canvas frame's coordinate. So we are using wrong coordinate system now. So I change our most points to root frame's coordinate.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wrong-coord-system v2

Update corresponding comment in header.

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I've verified that SelectWord works after apply this patch. However the patch does apply cleanly on master.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wrong-coord-system v3 (carry r+: roc)

Rebased.

try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3596a027afa0

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: wrong-coord-system v4 (carry r+: roc)

Rebased.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9bbad391201

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9bbad391201