1088562 - UITour: Doorhanger button text on gum build lacks sufficient contrast

Status: RESOLVED INVALID

(Firefox :: General, defect)

Description

[Alex Gibson [:agibson]]

Attachment: gum-doorhanger.png

The UITour doorhanger button text and close (x) button is very difficult to read with the dark theme styling applied (please see attached screenshot with areas highlighted in red).

Comment 1

[Matthew N. [:MattN]]

Brian, is this something you can fix as part of or a follow-up to bug 1053434?

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Matthew N. [:MattN] (behind on reviews - focused on Loop) from comment #1)
> Brian, is this something you can fix as part of or a follow-up to bug
> 1053434?

Yes - I'll make sure to include this in the secondary UI patch.

Comment 3

[Brian Grinstead [:bgrins]]

Unblocking 1053434 and 1085703 since these doorhanger changes are going to be done in a follow up (1090548)

Comment 4

[Alex Gibson [:agibson]]

Since i filed this bug it seems the UITour doorhanger in the latest gum build has reverted back to the light color scheme?

Not sure if that makes this bug now invalid, but I will leave it up to you folks to decide the course of action here :)

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Alex Gibson [:agibson] from comment #4)
> Since i filed this bug it seems the UITour doorhanger in the latest gum
> build has reverted back to the light color scheme?
> 
> Not sure if that makes this bug now invalid, but I will leave it up to you
> folks to decide the course of action here :)

Right, the doorhangers are going to stay light for v1.  Going to leave this open so I don't forget about it for Bug 1090548.

Comment 6

[Brian Grinstead [:bgrins]]

This used to be a problem, but since we aren't doing the secondary UI theming for now it isn't anymore.