Closed Bug 1088562 Opened 6 years ago Closed 6 years ago

UITour: Doorhanger button text on gum build lacks sufficient contrast

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: agibson, Unassigned)

References

Details

Attachments

(1 file)

Attached image gum-doorhanger.png
The UITour doorhanger button text and close (x) button is very difficult to read with the dark theme styling applied (please see attached screenshot with areas highlighted in red).
Brian, is this something you can fix as part of or a follow-up to bug 1053434?
Blocks: 1053434
Flags: needinfo?(bgrinstead)
(In reply to Matthew N. [:MattN] (behind on reviews - focused on Loop) from comment #1)
> Brian, is this something you can fix as part of or a follow-up to bug
> 1053434?

Yes - I'll make sure to include this in the secondary UI patch.
Flags: needinfo?(bgrinstead)
Unblocking 1053434 and 1085703 since these doorhanger changes are going to be done in a follow up (1090548)
Blocks: 1090548
No longer blocks: 1053434
Since i filed this bug it seems the UITour doorhanger in the latest gum build has reverted back to the light color scheme?

Not sure if that makes this bug now invalid, but I will leave it up to you folks to decide the course of action here :)
(In reply to Alex Gibson [:agibson] from comment #4)
> Since i filed this bug it seems the UITour doorhanger in the latest gum
> build has reverted back to the light color scheme?
> 
> Not sure if that makes this bug now invalid, but I will leave it up to you
> folks to decide the course of action here :)

Right, the doorhangers are going to stay light for v1.  Going to leave this open so I don't forget about it for Bug 1090548.
This used to be a problem, but since we aren't doing the secondary UI theming for now it isn't anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.