Closed Bug 1088568 Opened 9 years ago Closed 9 years ago

Remove reference to non-existing loop-call.png

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36

People

(Reporter: dao, Assigned: lubin.davidg, Mentored)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 1 obsolete file)

This patch contains the same changes. Please read my comment for details.
948 bytes, patch
Details | Diff | Splinter Review 
This is my first bug. So, please can I know what is to be replaced after we remove the mentioned reference? Or I will have to read the entire associated code to find it out myself what is to be placed at that place.

Or, we just have to remove those lines?
There's nothing this needs to be replaced with, it's just dead code that can go away.
This was my first bug, so I apologize if I made any mistakes with the uploading process. Please let me know if I did something incorrectly.
Attachment #8511569 - Flags: review?(dao)
Hi I would like this to be the first bug I fix can I work on it?
Hi I would like this to be the first bug I fix can I work on it?
Comment on attachment 8511569 [details] [diff] [review]
Patch file with reference removed

Thanks! :)
Attachment #8511569 - Flags: review?(dao) → review+
Assignee: nobody → lubin.davidg
Keywords: checkin-needed
Hi Dao. Should I attempt to check in the updated file or does someone else normally do it? Do I have the necessary permissions?
patch failed to apply:

renamed 1088568 -> browser.patch
applying browser.patch
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh browser.patch

could you take a look and maybe provide a try run to make sure everything works. Thanks!
Keywords: checkin-needed
Hi Carsten,

I'm sorry that the previous patch didn't work. I'm still new to this, and it seems I overlooked the instructions for creating mercurial patches. I made the previous patch using the diff command. Do you think that might explain it failing to be applied?

I attached a new patch, which was created using mercurial but is otherwise identical to the previous one. Unfortunately, I do not have access to the try server at this time. Could you please let me know if it works?

Thanks.
Attachment #8511569 - Attachment is obsolete: true
Attachment #8512115 - Flags: feedback?(dao)
Attachment #8512115 - Flags: checkin?(cbook)
https://hg.mozilla.org/integration/fx-team/rev/4651f5f4e29b
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
Attachment #8512115 - Flags: feedback?(dao)
Attachment #8512115 - Flags: checkin?(cbook)
https://hg.mozilla.org/mozilla-central/rev/4651f5f4e29b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.