1088585 - [v2.2] Fix test_dialer_make_call jenkins failure

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Robert Chira [:RobertC]]

test_dialer_make_call started failing on Jenkins with the following failure:

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.8.4-py2.7.egg/marionette/marionette_test.py", line 264, in run
testMethod()
File "/var/jenkins/1/workspace/flame-kk-319.b2g-inbound.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_dialer.py", line 22, in test_dialer_make_call
self.assertEqual('normal', self.data_layer.current_audio_channel)
AssertionError: 'normal' != u'none'

Test needs to be updated.

Comment 1

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25488

Because of the patch in Bug 1079810 the audio channel is no longer initialized when we launch the phone app.

It looks like there was additional power consumption caused by the audio channel being initialized by default.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8510951 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25488

This one-line patch is exactly the fix we need.

Comment 3

[Viorela Ioia [:viorela]]

Comment on attachment 8510951 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25488

Merged in: https://github.com/mozilla-b2g/gaia/commit/83eae5ce80184fd221ae719f690caba66bdb2c78

Comment 4

[Johan Lorenzo [:jlorenzo]]

Per 1079810 comment 49, we need to uplift the modification to 2.1 too. Can you do it Viorela?

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> Per 1079810 comment 49
Per bug 1079810 comment 49

Comment 6

[Robert Chira [:RobertC]]

I will uplift the fix once the PR from bug 1079810 comment 49 is merged.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Bug 1079810 comment 49 is an actual 2.1 commit.

Comment 8

[Robert Chira [:RobertC]]

The test on v2.1 is a bit different from master, this is why it isn't failing.

I uplifted the test change in Bug 1011000.
The PR from here does not need to be uplifted because the test change contains the fix.