1088686 - [Integration] SHB quick settings dialog test failing in 2.1

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alberto Pastor [:albertopq]]

Reproed locally

5) Software Home Button - Quick Settings Dialog Proper layout for quick settings data dialog:
05:14:30     INFO -    JavaScriptError: (17) TypeError: dialog is null
05:14:30     INFO -    Remote Stack:
05:14:30     INFO -    execute_script @undefined, line undefined
05:14:30     INFO -    inline javascript, line 64
05:14:30     INFO -    src: "      dialog.classList.add('visible');"
05:14:30     INFO -        at Error.MarionetteError (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)
05:14:30     INFO -        at Object.Client._handleCallback (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)
05:14:30     INFO -        at /builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
05:14:30     INFO -        at TcpSync.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
05:14:30     INFO -        at Object.send (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
05:14:30     INFO -        at Object.Client._sendCommand (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
05:14:30     INFO -        at Object._executeScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1468:19)
05:14:30     INFO -        at Object.executeScript (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:1208:19)
05:14:30     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/system/test/marionette/software_home_quick_setting_dialog_test.js:31:12)

Comment 1

[Alberto Pastor [:albertopq]]

Kevin, sorry to bother you again, but since you reviewed the patch in Bug 796428, I need some info. It seems that the failing test is expecting a selector ('#quick-setting-data-enabled-dialog') that is not in v2.1. That selector was introduced on Bug 796428. Should we uplift that or disable the test?

Comment 2

[Kevin Grandon :kgrandon]

This feature is not present on v2.1, so I think we should disable the test, or refactor the test to use another dialog. Mike - what do you think?

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Ahh yeah didn't realize this feature is not present on 2.1. I think the appropriate thing to do is remove the test and associated css. PR coming right up.

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] remove all traces of quick settings data enabled

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8512311 [details] [review]
[Gaia PR] remove all traces of quick settings data enabled

Sounds good to me. Thanks.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/86d578c185879459d80240d24852b1a907a67fd8