1089029 - Invalid mochitests skipped in dom/base/test/mochitest.ini

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kelsey Gilbert [:jgilbert]]

> 16:07:15     INFO -  Warning: test_XHR_timeout.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_bug357450.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_bug380418.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_bug402150.html^headers^ from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test
> 16:07:15     INFO -  Warning: test_bug493881.js from manifest /builds/slave/test/build/tests/mochitest/tests/content/base/test/mochitest.ini is not a valid test

Comment 1

[Vaibhav (:vaibhav1994)]

These have been shifted to dom/base/test/mochitest.ini

Comment 2

[Vaibhav (:vaibhav1994)]

Attachment: manifest.patch

Try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=97681dfa24b7

Comment 3

[Vaibhav (:vaibhav1994)]

Comment on attachment 8514336 [details] [diff] [review]
manifest.patch

The jobs are green and the warnings are no longer there for the above tests. :jmaher, please review this too!

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8514336 [details] [diff] [review]
manifest.patch

Review of attachment 8514336 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 5

[Carsten Book [:Tomcat]]

Hi Vaibhav, patch import failed see:

patching file dom/base/test/mochitest.ini
Hunk #3 FAILED at 403
1 out of 4 hunks FAILED -- saving rejects to file dom/base/test/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh manifest3.patch

Could you take a look, thanks!

Comment 6

[Vaibhav (:vaibhav1994)]

Attachment: manifest.patch

Fixed for bitrot.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e06eeccb20

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a2e06eeccb20