Open Bug 1087558 Opened 7 years ago Updated 7 years ago
Assert when a mochitest manifest entry is 'not a valid test'
I had tests that were not running because the files started were like `test-foo.html` instead of `test_foo.html`, and the only message was a warning buried in the mochitest spew about them 'not being valid tests'. It should assert.
would you want this as a 'test-unexpected-fail' in the log file? how would you like the notification to be shown?
(In reply to Joel Maher (:jmaher) from comment #1) > would you want this as a 'test-unexpected-fail' in the log file? how would > you like the notification to be shown? No, this is not a test error, it's a manifest error. Just throw an assert from python.
Sadly at the moment I think we still have junk in our manifests (from when we auto-converted from Makefiles) that means we can't make this fatal yet.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4) > Sadly at the moment I think we still have junk in our manifests (from when > we auto-converted from Makefiles) that means we can't make this fatal yet. I'm willing do to the mechanical patches to fix this.
:vaibhav, there are a lot of dependencies here, this is additional manifest work you could easily help out on!
I'd like to note that while it's easy to just remove these, since they're already not being run, a bunch of them look like valid tests. A module owner/peer should check that we can just remove them.
You need to log in before you can comment on or make changes to this bug.