1089102 - Firefox Hello has poor RTL UI

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P5)

Description

[Tomer Cohen :tomer]

Attachment: Screenshot (two frames animation)

Although Firefox Hello main screen looks well on RTL builds of Aurora, clicking on few buttons revel some missing functionality. 

A. Preferences button doesn't show preferences menu.
B. URL/email fields doesn't align to the left (dir=ltr).
C. Some screens such as the call quality doesn't have dir=rtl although they contain RTL content.

Comment 1

[u279076]

I think we may want to consider this blocking Loop 34.

Comment 2

[Maire Reavy [:mreavy]]

Hi Tomer -- How is the functionality in RTL builds?  Are you able to make calls?

Comment 3

[:shell escalante]

need to discuss with UX priority on all bugs tagged [RTL] for prioritization

Comment 4

[:shell escalante]

can pull in depending on when full RTL review is done.

Comment 5

[:shell escalante]

pending RTL full review and prioritization of bugs - moving to 39 at least

Comment 6

[:shell escalante]

shell: group with other RTL bugs and the review...

Comment 7

[Mark Banner (:standard8)]

Removing old NI. I'm guessing in-call isn't too bad as we haven't had any other report. Bug 1091800 will hopefully do a complete review soon.

Comment 8

[Stamimail]

The Gear Button (Settings) dialog is covered.

Comment 9

[Mark Banner (:standard8)]

Attachment: Make the Loop settings menu be displayed properly in the panel for rtl locales.

This fixes the dropdown menu. The other items originally mentioned aren't an issue now.

There's still some imperfections in the panel etc, but I think it makes it good enough now that we can leave them to other bugs/review bug 1091800.

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8609380 [details] [diff] [review]
Make the Loop settings menu be displayed properly in the panel for rtl locales.

Review of attachment 8609380 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it! Looks good when I tried it :)

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d8cde1084b38

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d8cde1084b38

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 8609380 [details] [diff] [review]
Make the Loop settings menu be displayed properly in the panel for rtl locales.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello
[User impact if declined]: RTL locales can't access the settings menu - it is shown off window.
[Describe test coverage new/current, TreeHerder]: Landed in m-c, css changes only
[Risks and why]: Minor only small changes
[String/UUID change made/needed]: None

Although this affects beta, not requesting uplift to there as this would need more work to extract parts of various previous patches to get everything working right. Moving this forward to aurora seems like a reasonable balance.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/07f7031e885b

Comment 15

[Bogdan Maris, Desktop QA]

We did some exploratory testing using Firefox 40 beta 7 (ar) build with calls between Windows 7 64-bit, Mac OS X 10.10.4, Windows 10 32-bit and Ubuntu 14.04 32-bit, and can confirm that the UI looks good on all platforms. We did encountered a crash on FF40 though, but it`s not related to RTL builds, bug 1187308.

Comment 16

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Verification on Beta 40 should suffice.